Merge "require release note pages to exist before adding the link"

2016-06-02 07:58:28 +00:00 · 2016-06-02 07:58:28 +00:00 · 2c04803762
commit 2c04803762
parent d8f3e80920 f947d43cc9
27 changed files with 19 additions and 26 deletions
--- a/deliverables/newton/debtcollector.yaml
+++ b/deliverables/newton/debtcollector.yaml
@ -2,7 +2,6 @@
 launchpad: debtcollector
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/debtcollector/newton.html
 releases:
 - version: 1.4.0
  projects:
--- a/deliverables/newton/futurist.yaml
+++ b/deliverables/newton/futurist.yaml
@ -2,7 +2,6 @@
 launchpad: futurist
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/futurist/newton.html
 releases:
 - version: 0.14.0
  projects:
--- a/deliverables/newton/keystoneauth.yaml
+++ b/deliverables/newton/keystoneauth.yaml
@ -2,7 +2,6 @@
 launchpad: keystoneauth
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/keystoneauth/newton.html
 releases:
 - version: 2.5.0
  projects:
--- a/deliverables/newton/mox3.yaml
+++ b/deliverables/newton/mox3.yaml
@ -2,7 +2,6 @@
 launchpad: python-mox3
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/mox3/newton.html
 releases:
 - version: 0.15.0
  projects:
--- a/deliverables/newton/os-client-config.yaml
+++ b/deliverables/newton/os-client-config.yaml
@ -2,7 +2,6 @@
 launchpad: os-client-config
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: yes
-release-notes: http://docs.openstack.org/releasenotes/os-client-config/
 releases:
  - version: 1.17.0
    projects:
--- a/deliverables/newton/oslo.cache.yaml
+++ b/deliverables/newton/oslo.cache.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.cache
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslo.cache/newton.html
 releases:
 - version: 1.7.0
  projects:
--- a/deliverables/newton/oslo.concurrency.yaml
+++ b/deliverables/newton/oslo.concurrency.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.concurrency
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslo.concurrency/newton.html
 releases:
 - version: 3.8.0
  projects:
--- a/deliverables/newton/oslo.context.yaml
+++ b/deliverables/newton/oslo.context.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.context
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslo.context/newton.html
 releases:
 - version: 2.3.0
  projects:
--- a/deliverables/newton/oslo.i18n.yaml
+++ b/deliverables/newton/oslo.i18n.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.i18n
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslo.i18n/newton.html
 releases:
 - version: 3.6.0
  projects:
--- a/deliverables/newton/oslo.log.yaml
+++ b/deliverables/newton/oslo.log.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.log
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: yes
-release-notes: http://docs.openstack.org/releasenotes/oslo.log/newton.html
 releases:
  - version: 3.4.0
    projects:
--- a/deliverables/newton/oslo.messaging.yaml
+++ b/deliverables/newton/oslo.messaging.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.messaging
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslo.messaging/newton.html
 releases:
 - version: 5.0.0
  projects:
--- a/deliverables/newton/oslo.middleware.yaml
+++ b/deliverables/newton/oslo.middleware.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.middleware
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslo.middleware/newton.html
 releases:
 - version: 3.9.0
  projects:
--- a/deliverables/newton/oslo.policy.yaml
+++ b/deliverables/newton/oslo.policy.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.policy
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslo.policy/newton.html
 releases:
 - version: 1.7.0
  projects:
--- a/deliverables/newton/oslo.reports.yaml
+++ b/deliverables/newton/oslo.reports.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.reports
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslo.reports/newton.html
 releases:
 - version: 1.8.0
  projects:
--- a/deliverables/newton/oslo.rootwrap.yaml
+++ b/deliverables/newton/oslo.rootwrap.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.rootwrap
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslo.rootwrap/newton.html
 releases:
 - version: 4.2.0
  projects:
--- a/deliverables/newton/oslo.serialization.yaml
+++ b/deliverables/newton/oslo.serialization.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.serialization
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslo.serialization/newton.html
 releases:
 - version: 2.5.0
  projects:
--- a/deliverables/newton/oslo.service.yaml
+++ b/deliverables/newton/oslo.service.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.service
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslo.service/newton.html
 releases:
 - version: 1.9.0
  projects:
--- a/deliverables/newton/oslo.utils.yaml
+++ b/deliverables/newton/oslo.utils.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.utils
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslo.utils/newton.html
 releases:
 - version: 3.9.0
  projects:
--- a/deliverables/newton/oslo.vmware.yaml
+++ b/deliverables/newton/oslo.vmware.yaml
@ -2,7 +2,6 @@
 launchpad: oslo.vmware
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslo.vmware/newton.html
 releases:
 - version: 2.6.0
  projects:
--- a/deliverables/newton/oslotest.yaml
+++ b/deliverables/newton/oslotest.yaml
@ -2,7 +2,6 @@
 launchpad: oslotest
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/oslotest/newton.html
 releases:
 - version: 2.5.0
  projects:
--- a/deliverables/newton/python-keystoneclient.yaml
+++ b/deliverables/newton/python-keystoneclient.yaml
@ -2,7 +2,6 @@
 launchpad: python-keystoneclient
 send-announcements-to: openstack-announce@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/python-keystoneclient/newton.html
 releases:
 - version: 3.0.0
  projects:
--- a/deliverables/newton/python-novaclient.yaml
+++ b/deliverables/newton/python-novaclient.yaml
@ -2,7 +2,6 @@
 launchpad: python-novaclient
 send-announcements-to: openstack-announce@lists.openstack.org,openstack-dev@lists.openstack.org
 include-pypi-link: yes
-release-notes: http://docs.openstack.org/releasenotes/python-novaclient/mitaka.html
 releases:
  - version: 3.4.0
    projects:
--- a/deliverables/newton/python-openstackclient.yaml
+++ b/deliverables/newton/python-openstackclient.yaml
@ -2,7 +2,6 @@
 launchpad: python-openstackclient
 send-announcements-to: openstack-announce@lists.openstack.org
 include-pypi-link: yes
-release-notes: http://docs.openstack.org/releasenotes/python-openstackclient/newton.html
 releases:
  - version: 2.4.0
    projects:
--- a/deliverables/newton/stevedore.yaml
+++ b/deliverables/newton/stevedore.yaml
@ -2,7 +2,6 @@
 launchpad: stevedore
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/stevedore/newton.html
 releases:
 - version: 1.13.0
  projects:
--- a/deliverables/newton/taskflow.yaml
+++ b/deliverables/newton/taskflow.yaml
@ -2,7 +2,6 @@
 launchpad: taskflow
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/taskflow/newton.html
 releases:
 - version: 1.31.0
  projects:
--- a/deliverables/newton/tooz.yaml
+++ b/deliverables/newton/tooz.yaml
@ -2,7 +2,6 @@
 launchpad: python-tooz
 send-announcements-to: openstack-dev@lists.openstack.org
 include-pypi-link: true
-release-notes: http://docs.openstack.org/releasenotes/tooz/newton.html
 releases:
 - version: 1.35.0
  projects:
--- a/openstack_releases/cmds/validate.py
+++ b/openstack_releases/cmds/validate.py
@ -136,6 +136,25 @@ def main():
                errors.append('Space in send-announcements-to (%r) for %s' %
                              (announce_to, filename))

+        # Make sure the release notes page exists, if it is specified.
+        if 'release-notes' in deliverable_info:
+            notes_link = deliverable_info['release-notes']
+            if isinstance(notes_link, dict):
+                links = list(notes_link.values())
+            else:
+                links = [notes_link]
+            for link in links:
+                rn_resp = requests.get(link)
+                if (rn_resp.status_code // 100) == 2:
+                    print('Release notes at %s found' % link)
+                else:
+                    errors.append('Could not fetch release notes page %s: %s' %
+                                  (link, rn_resp.status_code))
+                    print('Found bad release notes link %s: %s' %
+                          (link, rn_resp.status_code))
+        else:
+            print('no release-notes specified')
+
        series_name = os.path.basename(
            os.path.dirname(filename)
        )