openstack/releases
Code Issues Proposed changes

remove unused function _guess_deliverable_type

Browse Source 
Change-Id: I60485fc67692f584afc281736f5f00623015f81a
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann
2018-02-21 18:48:40 -05:00
parent d8018e0d0c
commit 2dd325e486
2 changed files with 0 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
openstack_releases/cmds/validate.py
View File

@@ -838,14 +838,6 @@ def validate_branch_prefixes(deliv, messages):
branch.name, _VALID_BRANCH_PREFIXES)) branch.name, _VALID_BRANCH_PREFIXES))
def _guess_deliverable_type(deliverable_name, deliverable_info):
if 'tempest-plugin' in deliverable_name:
return 'tempest-plugin'
if 'type' in deliverable_info:
return deliverable_info['type']
return 'other'
def validate_stable_branches(deliv, workdir, series_name, messages): def validate_stable_branches(deliv, workdir, series_name, messages):
"Apply the rules for stable branches." "Apply the rules for stable branches."
header('Validate Stable Branches') header('Validate Stable Branches')

34
openstack_releases/tests/test_validate.py
View File

@@ -2521,40 +2521,6 @@ class TestValidateSeriesFirst(base.BaseTestCase):
self.assertEqual(0, len(self.msg.errors)) self.assertEqual(0, len(self.msg.errors))
class TestGuessDeliverableType(base.BaseTestCase):
def setUp(self):
super().setUp()
self.msg = validate.MessageCollector()
def test_explicit(self):
self.assertEqual(
'the-type',
validate._guess_deliverable_type(
'name',
{'type': 'the-type'},
),
)
def test_implicit_tempest_plugin(self):
self.assertEqual(
'tempest-plugin',
validate._guess_deliverable_type(
'foo-tempest-plugin',
{},
),
)
def test_default_other(self):
self.assertEqual(
'other',
validate._guess_deliverable_type(
'name',
{},
),
)
class TestValidateBranchPoints(base.BaseTestCase): class TestValidateBranchPoints(base.BaseTestCase):
def setUp(self): def setUp(self):