From 3013ead10cff47353aa0c807b2baa7066d28f49b Mon Sep 17 00:00:00 2001 From: Doug Hellmann Date: Wed, 19 Sep 2018 09:24:54 -0400 Subject: [PATCH] convert warning for missing repo to error If a release does not include all of the repositories in the deliverable report an error instead of a warning. Change-Id: I7980b204995647fc77657123fa8d7bb565b55247 Signed-off-by: Doug Hellmann --- openstack_releases/cmds/validate.py | 2 +- openstack_releases/tests/test_validate.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/openstack_releases/cmds/validate.py b/openstack_releases/cmds/validate.py index f0e94d52b3..56c38be2bb 100644 --- a/openstack_releases/cmds/validate.py +++ b/openstack_releases/cmds/validate.py @@ -1340,7 +1340,7 @@ def validate_new_releases(deliv, context): ) for missing in deliv.known_repo_names: if missing not in actual_repos: - context.warning( + context.error( 'release %s is missing %s, ' 'which appears in the repository-settings list' % (final_release.version, missing) diff --git a/openstack_releases/tests/test_validate.py b/openstack_releases/tests/test_validate.py index 05a94201af..5e51466beb 100644 --- a/openstack_releases/tests/test_validate.py +++ b/openstack_releases/tests/test_validate.py @@ -1840,8 +1840,8 @@ class TestValidateNewReleases(base.BaseTestCase): ) validate.validate_new_releases(deliv, self.ctx) self.ctx.show_summary() - self.assertEqual(1, len(self.ctx.warnings)) - self.assertEqual(0, len(self.ctx.errors)) + self.assertEqual(0, len(self.ctx.warnings)) + self.assertEqual(1, len(self.ctx.errors)) class TestValidateBranchPrefixes(base.BaseTestCase):