Merge "Upgrade hacking 1.x"

openstack_releases/cmds/check_diff_start.py

@@ -68,10 +68,7 @@ def main():
 
     def cleanup_workdir():
         if args.cleanup:
-            try:
+            shutil.rmtree(workdir, True)
-                shutil.rmtree(workdir)
-            except:
-                pass
         else:
             print('not cleaning up %s' % workdir)
     atexit.register(cleanup_workdir)

openstack_releases/cmds/list_changes.py

@@ -236,10 +236,7 @@ def main():
 
     def cleanup_workdir():
         if args.cleanup:
-            try:
+            shutil.rmtree(workdir, True)
-                shutil.rmtree(workdir)
-            except:
-                pass
         else:
             print('not cleaning up %s' % workdir)
     atexit.register(cleanup_workdir)

openstack_releases/cmds/new_release.py

@@ -162,10 +162,7 @@ def main():
 
     def cleanup_workdir():
         if args.cleanup:
-            try:
+            shutil.rmtree(workdir, True)
-                shutil.rmtree(workdir)
-            except:
-                pass
         else:
             print('not cleaning up %s' % workdir)
     atexit.register(cleanup_workdir)

openstack_releases/cmds/validate.py

@@ -1263,10 +1263,7 @@ def main():
 
     def cleanup_workdir():
         if args.cleanup:
-            try:
+            shutil.rmtree(workdir, True)
-                shutil.rmtree(workdir)
-            except:
-                pass
         else:
             print('not cleaning up %s' % workdir)
     atexit.register(cleanup_workdir)

openstack_releases/deliverable.py

@@ -80,7 +80,7 @@ def _collapse_deliverable_history(name, info):
             parsed_vers = pbr.version.SemanticVersion.from_pip_string(
                 str(r['version']))
             vers_tuple = parsed_vers.version_tuple()
-        except:
+        except Exception:
             # If we can't parse the version, it must be some sort
             # of made up legacy tag. Ignore the parse error
             # and include the value in our output.

openstack_releases/tests/test_validate.py

@@ -21,9 +21,9 @@ import fixtures
 import mock
 from oslotest import base
 
+from openstack_releases.cmds import validate
 from openstack_releases import defaults
 from openstack_releases import gitutils
-from openstack_releases.cmds import validate
 from openstack_releases import yamlutils
 
 

test-requirements.txt

@@ -2,7 +2,7 @@
 # of appearance. Changing the order has an impact on the overall integration
 # process, which may cause wedges in the gate later.
 
-hacking<0.11,>=0.10.0
+hacking>=1.0.0,<1.1.0
 
 fixtures>=3.0.0 # Apache-2.0/BSD
 python-subunit>=0.0.18 # Apache-2.0/BSD

tools/discover_branch_points.py

@@ -140,10 +140,7 @@ def main():
 
     def cleanup_workdir():
         if args.cleanup:
-            try:
+            shutil.rmtree(workdir, True)
-                shutil.rmtree(workdir)
-            except:
-                pass
     atexit.register(cleanup_workdir)
 
     branch_name = 'origin/stable/' + args.series

tools/verify_branches_and_late_releases.py

@@ -106,11 +106,8 @@ def main():
 
     def cleanup_workdir():
         if args.cleanup:
-            try:
             verbose('cleaning up temporary files in {}'.format(workdir))
-                shutil.rmtree(workdir)
+            shutil.rmtree(workdir, True)
-            except:
-                pass
         else:
             print('not cleaning up {}'.format(workdir))
     atexit.register(cleanup_workdir)

tox.ini

@@ -31,7 +31,6 @@ commands =
     {toxinidir}/tools/tox-log-command.sh list-changes {posargs}
 
 [testenv:pep8]
-deps = flake8>=2.2.4,<=2.4.1
 commands = flake8
 
 [testenv:bashate]
@@ -72,7 +71,7 @@ commands =
 # E501 skipped because some of the code files include templates
 #      that end up quite wide
 show-source = True
-ignore = E123,E125,E501
+ignore = E123,E125,E501,H405
 builtins = _
 exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,release-tag-*