openstack/releases
Code Issues Proposed changes

Fix announce email project names

Browse Source 
Argument naming ambiguity led to grabbing the wrong value. This updates
repo name handling to grab from the right input.

Change-Id: I4987fc012a07344cbc4290e33eae5b772270eb07
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
This commit is contained in:
Sean McGinnis 2019-04-18 11:33:37 -05:00
parent d4204f1af4
commit 46c68ab92c
No known key found for this signature in database
GPG Key ID: CE7EE4BFAF8D70C8
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openstack_releases/cmds/release_notes.py
View File

@ -23,7 +23,7 @@ def main():
formatter_class=argparse.RawDescriptionHelpFormatter) formatter_class=argparse.RawDescriptionHelpFormatter)
parser.add_argument("repo", metavar='path', action="store", parser.add_argument("repo", metavar='path', action="store",
help="repository directory, for example" help="repository directory, for example"
" 'openstack/cliff'", " 'openstack/cliff' or './'",
) )
parser.add_argument('repo_name', action='store', parser.add_argument('repo_name', action='store',
help='The name of the repository being released', help='The name of the repository being released',
@ -107,7 +107,7 @@ def main():
repo_path = os.path.abspath(args.repo) repo_path = os.path.abspath(args.repo)
notes = release_notes.generate_release_notes( notes = release_notes.generate_release_notes(
repo=args.repo, repo=args.repo_name,
repo_path=repo_path, repo_path=repo_path,
start_revision=args.start_revision, start_revision=args.start_revision,
end_revision=args.end_revision, end_revision=args.end_revision,

2
openstack_releases/release_notes.py
View File

@ -376,7 +376,7 @@ def generate_release_notes(repo, repo_path,
# release-announce@lists.openstack.org ML (except for # release-announce@lists.openstack.org ML (except for
# release-test and release candidates) # release-test and release candidates)
email_to = 'release-announce@lists.openstack.org' email_to = 'release-announce@lists.openstack.org'
if repo == 'openstack-release-test': if repo_name == 'openstack-release-test':
email_to = 'release-job-failures@lists.openstack.org' email_to = 'release-job-failures@lists.openstack.org'
elif is_release_candidate: elif is_release_candidate:
email_to = 'openstack-discuss@lists.openstack.org' email_to = 'openstack-discuss@lists.openstack.org'