openstack/releases
Code Issues Proposed changes

try to print a warning when a non-milestone project uses a pre-release

Browse Source 
We have a few cycle-with-intermediary projects using milestone
versioning. This change adds a warning to the list-changes output to
make these cases easier to spot and reject for next cycle.

Change-Id: Iaa4c4065c5d32aa297b88b8673434b8b4826a227
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2016-08-26 10:44:21 -04:00
parent b100807133
commit 4c387c8455
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
openstack_releases/cmds/list_changes.py
View File

@ -134,6 +134,9 @@ def main():
with open(filename, 'r') as f:
deliverable_info = yaml.load(f.read())
# By default assume the project does not use milestones.
uses_milestones = False
header('Team details')
if 'team' in deliverable_info:
team_name = deliverable_info['team']
@ -151,6 +154,7 @@ def main():
for t in repo.tags:
print(' %s' % t)
print('')
uses_milestones = 'release:cycle-with-milestones' in repo.tags
else:
print(('no deliverable %r found for team %r, '
'cannot report on governance status') %
@ -160,6 +164,8 @@ def main():
team_name)
else:
print('no team name given, cannot report on governance status')
if uses_milestones:
print('uses milestones')
series = os.path.basename(
os.path.dirname(
@ -174,6 +180,15 @@ def main():
# assume the releases are in order and take the last one
new_release = deliverable_info['releases'][-1]
# Warn if the new release looks like a milestone release but
# the project does not use milestones.
if not uses_milestones:
for pre_indicator in ['a', 'b', 'rc']:
if pre_indicator in new_release['version']:
print(('WARNING: %s looks like a pre-release '
'but %s does not use milestones') %
(new_release['version'], deliverable_name))
# build a map between version numbers and the release details
by_version = {
str(r['version']): r