openstack/releases
Code Issues Proposed changes

Remove description to simplify release-announce

Browse Source 
Current release-announce job proceeds with installing the package being
released, just in order to compute the "description" of the package and
include it in the announcement. This is costly and error-prone, for very
little gain.

This change removes the costly computation of the "description". The
"project_name" was overridden by $ZUUL_PROJECT anyway. The email
template already has logic to skip the description if it's not provided.

Change-Id: I5a60556f7d321fd4c37f1424509469da28a1eec9
This commit is contained in:
Thierry Carrez 2024-09-12 16:57:18 +02:00
parent e6e0b0553e
commit 51e11ed1a4
1 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tools/announce.sh
View File

@ -168,26 +168,15 @@ echo "$DIFF_START to $VERSION on $SERIES"
relnotes_file="$RELNOTESDIR/$SHORTNAME-$VERSION"
# As we use importlib to retrieve information we have to pass the
# importable name of the module, example: oslo.messaging => oslo_messaging
modified_shortname=${SHORTNAME//\./_}
# ensure that the package is a valid package that can be imported by
# importlib.metadata
python -m pip install .
project_name=$(python -c "import importlib.metadata; print(importlib.metadata.metadata('${modified_shortname}')['Name'])" || true)
if [ -n "${project_name}" ] ; then
description=$(python -c "import importlib.metadata; print(importlib.metadata.metadata('${modified_shortname}')['Summary'])")
else
# As a last resort, guess that the project name may be the same as that
# of the local working directory at the point this script is invoked.
project_name="$(basename $(pwd))"
fi
# If we are running in the context of a Zuul CI system,
# we can just infer the project name from the repo name it supplies.
if [ -n "$ZUUL_PROJECT" ] ; then
project_name="$(basename ${ZUUL_PROJECT})"
else
# As a last resort, guess that the project name may be the same as that
# of the local working directory at the point this script is invoked.
project_name="$(basename $(pwd))"
fi
echo
@ -200,7 +189,6 @@ release-notes \
--publishing-dir-name "$SHORTNAME" \
. "$project_name" "$DIFF_START" "$VERSION" \
$include_pypi_link \
--description "$description" \
| tee $relnotes_file
echo