openstack/releases
Code Issues Proposed changes

Make check_approval not require openstack_governance

Browse Source 
Since the job will have to run on the Zuul executor, it needs to
only rely on stdlib, yaml and requests (which are already installed
on the executor).

Change-Id: Id4e5a88d352e95402d0899deceade6fed8146619
This commit is contained in:
Thierry Carrez 2019-12-17 18:21:29 +01:00
parent f1bb2b5a60
commit 53fba5642b
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tools/check_approval.py
View File

@ -23,12 +23,13 @@ import logging
import os import os
import sys import sys
from openstack_governance import governance
import requests import requests
from requests.packages import urllib3 from requests.packages import urllib3
import yaml import yaml
GOVERNANCE_SITE = 'https://opendev.org/openstack/governance/raw/branch/master/'
PROJECTS_YAML = 'reference/projects.yaml'
GERRIT_URL = 'https://review.opendev.org/' GERRIT_URL = 'https://review.opendev.org/'
LOG = logging.getLogger(__name__) LOG = logging.getLogger(__name__)
@ -55,9 +56,10 @@ def get_liaisons(team):
class GerritChange(object): class GerritChange(object):
def __init__(self, gov_data, changeid): def __init__(self, changeid):
# Load governance data # Load governance data
self.gov_data = governance.Governance.from_remote_repo() r = requests.get(GOVERNANCE_SITE + PROJECTS_YAML)
self.gov_data = yaml.safe_load(r.text)
# Grab changeid details from Gerrit # Grab changeid details from Gerrit
call = 'changes/%s' % changeid + \ call = 'changes/%s' % changeid + \
@ -96,7 +98,7 @@ class GerritChange(object):
for deliv_file in self.deliv_files: for deliv_file in self.deliv_files:
team = get_team(deliv_file) team = get_team(deliv_file)
try: try:
govteam = self.gov_data.get_team(team) govteam = self.gov_data[team]
except ValueError: except ValueError:
print('✕ %s mentions unknown team %s' % (deliv_file, team)) print('✕ %s mentions unknown team %s' % (deliv_file, team))
approved = False approved = False
@ -104,15 +106,15 @@ class GerritChange(object):
# Check that deliverable is indeed defined in governance team # Check that deliverable is indeed defined in governance team
delivname, _ = os.path.splitext(os.path.basename(deliv_file)) delivname, _ = os.path.splitext(os.path.basename(deliv_file))
if delivname not in govteam.deliverables: if delivname not in govteam['deliverables']:
print('✕ %s not in %s governance' % (deliv_file, team)) print('✕ %s not in %s governance' % (deliv_file, team))
approved = False approved = False
break break
# Fetch PTL and release liaisons # Fetch PTL and release liaisons
liaisons = get_liaisons(team) liaisons = get_liaisons(team)
if 'email' in govteam.ptl: if 'email' in govteam['ptl']:
liaisons.append(govteam.ptl['email']) liaisons.append(govteam['ptl']['email'])
LOG.debug('%s needs %s' % (deliv_file, liaisons)) LOG.debug('%s needs %s' % (deliv_file, liaisons))
for approver in self.approvers: for approver in self.approvers:
@ -134,8 +136,7 @@ def main(args=sys.argv[1:]):
if (args.debug): if (args.debug):
logging.basicConfig(level=logging.DEBUG) logging.basicConfig(level=logging.DEBUG)
gov_data = governance.Governance.from_remote_repo() change = GerritChange(args.changeid)
change = GerritChange(gov_data, args.changeid)
if not change.is_approved(): if not change.is_approved():
sys.exit(1) sys.exit(1)