openstack/releases
Code Issues Proposed changes

add validation check for independent modules

Browse Source 
Enforce the rule that independent projects do not belong in the
series-specific deliverables files.

Change-Id: Ia74189c9572cc8c648657f4c7937cd3c06d9e486
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2016-03-18 15:56:32 -04:00
parent e42b66139a
commit 54dc431171
1 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
openstack_releases/cmds/validate.py
View File

@ -22,6 +22,7 @@ import argparse
import atexit
import glob
import os
import os.path
import re
import shutil
import tempfile
@ -34,6 +35,7 @@ from requests.packages import urllib3
from openstack_releases import defaults
from openstack_releases import gitutils
from openstack_releases import governance
from openstack_releases import versionutils
urllib3.disable_warnings()
@ -67,6 +69,16 @@ def main():
% defaults.RELEASE)
filenames = glob.glob('deliverables/' + defaults.RELEASE + '/*.yaml')
team_data = governance.get_team_data()
independent_repos = set(
r.name
for r in governance.get_repositories(
team_data,
tags=['release:independent'],
)
)
independent_checks = set()
errors = []
workdir = tempfile.mkdtemp(prefix='releases-')
@ -120,6 +132,10 @@ def main():
errors.append('Space in send-announcements-to (%r) for %s' %
(announce_to, filename))
series_name = os.path.basename(
os.path.dirname(filename)
)
prev_version = None
prev_projects = set()
for release in deliverable_info['releases']:
@ -129,6 +145,21 @@ def main():
errors.append(e)
for project in release['projects']:
# If the project is release:independent, make sure
# that's where the deliverable file is.
chk = (series_name, project['repo'])
if chk not in independent_checks:
if project['repo'] in independent_repos:
if series_name != '_independent':
msg = ('%s uses the independent release model '
'and should be in the _independent '
'directory not in %s') % (project['repo'],
filename)
print(msg)
errors.append(msg)
independent_checks.add(chk)
# Check the SHA specified for the tag.
print('%s SHA %s ' % (project['repo'],
project['hash']),
end='')