From 59cabc808ccefb7c945e3f85efe9dad267dc5b90 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herv=C3=A9=20Beraud?= Date: Tue, 26 Oct 2021 16:09:15 +0200 Subject: [PATCH] Allow to add reviewers for DPL teams These teams are PTL-less and not necessary define their release liaison openstack/release/data/release_liaison.yaml. The problem is that their official reviewers arn't necessarly detected. These changes allow to consider these release liaisons folks. Change-Id: I29295dddb2619043a43957e5e2c2f64d0787784b --- openstack_releases/cmds/get_contacts.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/openstack_releases/cmds/get_contacts.py b/openstack_releases/cmds/get_contacts.py index 6e1e96a9f6..066b112c7d 100644 --- a/openstack_releases/cmds/get_contacts.py +++ b/openstack_releases/cmds/get_contacts.py @@ -63,7 +63,15 @@ def main(): file=sys.stderr) return 1 - contacts.add(Contact(team_data.ptl)) + # Some teams may be PTL-less + if team_data.ptl.get('email', None): + contacts.add(Contact(team_data.ptl)) + # At this point we consider this team as a team following the + # DPL governance model + else: + rel_liaisons = team_data.liaisons['release'] + for liaison in rel_liaisons: + contacts.add(Contact(liaison)) if args.liaisons or args.all: for liaison in liaison_data.get(team_name.lower(), []):