openstack/releases
Code Issues Proposed changes

update the pypi permission validation to handle _ in names

Browse Source 
Change-Id: Idd87c39d062452eb7f3a4eed2bf7cb62713b6126
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2018-02-16 16:28:29 -05:00
parent be16bbf2e0
commit 8454def9cf
1 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
openstack_releases/cmds/validate.py
View File

@ -557,8 +557,18 @@ def validate_pypi_permissions(deliverable_info, zuul_projects, workdir,
) )
continue continue
# Names like "openstack_requirements" are translated to
# "openstack-requirements" in the PyPI API.
sdist = sdist.replace('_', '-')
print('sdist name {!r}'.format(sdist))
uploaders = pythonutils.get_pypi_uploaders(sdist) uploaders = pythonutils.get_pypi_uploaders(sdist)
if 'openstackci' not in uploaders: if not uploaders:
mk_error(
'could not find users with permission to upload packages '
'for {}. Is the sdist name correct?'.format(sdist)
)
elif 'openstackci' not in uploaders:
mk_error( mk_error(
'openstackci does not have permission to upload packages ' 'openstackci does not have permission to upload packages '
'for {}. Current owners include: {}'.format( 'for {}. Current owners include: {}'.format(
@ -1302,15 +1312,13 @@ def main():
mk_warning, mk_warning,
mk_error, mk_error,
) )
# TODO(smcginnis): Problems seen validating openstack/requirements validate_pypi_permissions(
# branching. Need to investigate that failure before reenabling this. deliverable_info,
# validate_pypi_permissions( zuul_projects,
# deliverable_info, workdir,
# zuul_projects, mk_warning,
# workdir, mk_error,
# mk_warning, )
# mk_error,
# )
validate_gitreview(deliverable_info, workdir, mk_warning, mk_error) validate_gitreview(deliverable_info, workdir, mk_warning, mk_error)
validate_releases( validate_releases(
deliverable_info, deliverable_info,