From aa3ab893c20612c7489d0d13ee1612e0fbd1ae8a Mon Sep 17 00:00:00 2001 From: Sean McGinnis Date: Mon, 8 Jul 2019 14:28:58 -0500 Subject: [PATCH] Skip branch checking on EOL deliverables If we make modifications to a deliverable file for whatever reason and that series is EOL, the validation code would still check that branches existed and therefore fail. The stable/$series branch most likely is deleted after going EOL, so the validation code would think there was a need for a new branch to be created, then fail if the last release done was not the same point as the branch. This updates the validation logic to check up front if the deliverable is EOL and skip these checks. Change-Id: Ib5be3c0ba7283021301d278fcb362432f9a7d5cb Signed-off-by: Sean McGinnis --- openstack_releases/cmds/validate.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/openstack_releases/cmds/validate.py b/openstack_releases/cmds/validate.py index a880712528..38e782e13c 100644 --- a/openstack_releases/cmds/validate.py +++ b/openstack_releases/cmds/validate.py @@ -1437,6 +1437,10 @@ def validate_stable_branches(deliv, context): branch_mode = deliv.stable_branch_type + if deliv.releases and deliv.releases[-1].is_eol: + print('rule does not apply to end-of-life repos, skipping') + return + known_series = sorted(list( d for d in os.listdir('deliverables') if not d.startswith('_')