9504e96b5d
We recently observed that this check was skipped. Indeed it was
possible to propose a bugfix version on the first release of a series
without facing validation errors [1].
The described situation was allowed by checks that we introduced
during Wallaby [2]. Those was designed to ensure that we can
build sdist from the proposed tag. Indeed, they temporarly created
the new git tag to build sdist from it. However we never delete this
tag after our tests so this temporary tag is see as an existing tag
and so that led us to the observed bug.
Our validation check that the first version number of series isn't a
bugfix after it tried to build the sdist from the new tag, so, without
this patch the tag newly created by the sdist check remains available
in the repo, and so a couple of next checks are skipped, including the
validation of the version number, because these checks are decorated
to ignore existing tags.
Indeed the function decorated with `skip_existing_tags` detect this
temporary tag as an existing tag, so, the decorated functions are
skipped.
We should notice that it surely impacted other checks in the same manner.
Indeed, all validation functions decorated with this function
`skip_existing_tags` are impacted by this bug.
Hopefully it didn't have too much side effects.
These changes delete the temporary tag after usage to ensure to restore
the initial environment and to stop skipping next checks.
[1] https://review.opendev.org/c/openstack/releases/+/795836
[2]
|
||
|---|---|---|
| data | ||
| deliverables | ||
| doc | ||
| openstack_releases | ||
| templates | ||
| tools | ||
| .gitignore | ||
| .gitreview | ||
| .stestr.conf | ||
| .zuul.yaml | ||
| bindep.txt | ||
| CONTRIBUTING.rst | ||
| LICENSE | ||
| README.rst | ||
| requirements.txt | ||
| setup.cfg | ||
| setup.py | ||
| test-requirements.txt | ||
| tox.ini | ||
| watched_queries.yml | ||
| yamllint.yml | ||
OpenStack Releases
This repository is used to drive release automation for OpenStack release deliverables, ultimately publishing them on the https://releases.openstack.org/ website.
Changes to this repository are proposed using Gerrit at https://review.opendev.org. This repository is managed by the OpenStack Release Management team.
For more information on how to use this repository, please read our reference documentation.
Who should use this repository
All official OpenStack software should go through the OpenStack Release Management team team to produce releases. Exceptions to this rule are granted by the Technical Committee and documented in the openstack/governance repository ('release-management' key in reference/projects.yaml).
Deliverables managed by teams not under OpenStack governance should follow the tagging instructions in the infra manual.
More information
You can reach the Release Management team on the #openstack-release channel on OFTC IRC <https://www.oftc.net/>, or by sending an email with '[release]' as a subject prefix to the openstack-discuss mailing-list.