From 7e91070789187d9e6b5ac2b57ca755504e058e32 Mon Sep 17 00:00:00 2001 From: Matthew Thode Date: Mon, 11 Jun 2018 12:52:05 -0500 Subject: [PATCH] make requirements check job check for minimum version definitions. While we don't track the minimum version of a given requirement in requirements.txt we still need to ensure that they exist. Change-Id: I84bfbc3a1db4032ee1a2b5995e6930978be42828 Closes-Bug: #1776247 --- openstack_requirements/check.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/openstack_requirements/check.py b/openstack_requirements/check.py index 92d62edba0..60d7ada464 100644 --- a/openstack_requirements/check.py +++ b/openstack_requirements/check.py @@ -155,6 +155,11 @@ def _validate_one(name, reqs, blacklist, global_reqs): "not match openstack/requirements value : %s" % ( name, str(req), str(global_reqs[name]))) return True + # check for minimum being defined + min = [s for s in req.specifiers.split(',') if '>' in s] + if not min: + print("Requirement for package %s has no lower bound" % name) + return True for extra, count in counts.items(): if count != len(global_reqs[name]): print("Package %s%s requirement does not match "