From d875d3d4dd744c3b183e80810cf60b70ae8fb5d6 Mon Sep 17 00:00:00 2001
From: Riccardo Pittau <elfosardo@gmail.com>
Date: Wed, 26 Apr 2023 11:07:01 +0200
Subject: [PATCH] Add pysnmp-lextudio and pyasn1-lextudio

The pysnmp library is not maintained since 4 years and it's
now incompatible with other related libraries like pyasn1.
Deprecate it and add its fork pysnmp-lextudio with its
dependencies pyasn1-lextudio and pyasn1-modules-lextudio

For more info on the new pysnmp ecosystem please look at
https://github.com/etingof/pysnmp/issues/429

[Q] Is the library actively maintained?
[A] Yes.

[Q] Is the library good code?
[A] Yes.

[Q] Is the library python 3 compatible?
[A] Yes.

[Q] Is the library license compatible?
[A] Yes. BSD

[Q] Is the library already packaged in the distros we target
    (Ubuntu latest / Fedora latest)?
[A] No.

[Q] Is the function of this library already covered by other
    libraries in global-requirements.txt?
[A] Yes, but they're unmaintained or not part of the same ecosystem,
    which brings incompatibility in the long term (see the issue with
    pyasn1 0.5.0 update that is incompatible with pysnmp, even if it
    is one of its dependencies!)

Change-Id: I90274181c1e027d9b17a556fa1ac4767cbf6b5d0
---
 global-requirements.txt | 8 ++++++++
 upper-constraints.txt   | 3 +++
 2 files changed, 11 insertions(+)

diff --git a/global-requirements.txt b/global-requirements.txt
index bd71a1d6ee..a7e1f30658 100644
--- a/global-requirements.txt
+++ b/global-requirements.txt
@@ -244,7 +244,15 @@ pyngus  # Apache-2.0
 pyOpenSSL  # Apache-2.0
 pyparsing  # MIT
 pyroute2!=0.5.4,!=0.5.5,!=0.7.1;sys_platform!='win32'  # Apache-2.0 (+ dual licensed GPL2)
+# pysnmp library is not maintained since 4 years, it is
+# not recommended to use it, use its fork pysnmp-lextudio instead
+# in conjunction with its dependencies pyasn1-lextudio and
+# pyasn1-modules-lextudio
 pysnmp  # BSD
+pysnmp-lextudio  # BSD
+pyasn1-lextudio  # BSD
+pyasn1-modules-lextudio  # BSD
+
 pystache  # MIT
 pysaml2!=4.0.3,!=4.0.4,!=4.0.5,!=4.0.5rc1,!=4.1.0,!=4.2.0,!=4.3.0,!=4.4.0,!=4.6.0  # Apache-2.0
 
diff --git a/upper-constraints.txt b/upper-constraints.txt
index a6d911be06..6996b58663 100644
--- a/upper-constraints.txt
+++ b/upper-constraints.txt
@@ -72,6 +72,7 @@ nosehtmloutput===0.0.7
 waitress===2.1.2
 os-refresh-config===13.1.0
 pysnmp===4.4.12
+pysnmp-lextudio===5.0.26
 types-PyYAML===6.0.12.9
 Mako===1.2.4
 pyScss===1.4.0
@@ -437,6 +438,7 @@ pywinrm===0.4.3
 botocore===1.29.118
 xmltodict===0.13.0
 pyasn1===0.4.8
+pyasn1-lextudio===1.1.2
 directord===0.12.0
 oslo.rootwrap===7.0.1
 Django===3.2.18
@@ -513,6 +515,7 @@ mitba===1.1.1
 python-masakariclient===8.1.0
 Werkzeug===2.2.3
 pyasn1-modules===0.3.0
+pyasn1-modules-lextudio===0.2.9
 APScheduler===3.10.1
 xmlschema===2.2.3
 python-troveclient===8.1.0