openstack/reviewstats
Code Issues Proposed changes

Move age_sorted lists into gen_stats()

Browse Source 
Change-Id: Iafe420dc1d1c72f8fd769beeab1eb76eec582333
Reviewed-on: https://review.openstack.org/36068
Approved: Russell Bryant <rbryant@redhat.com>
Reviewed-by: Russell Bryant <rbryant@redhat.com>
Tested-by: Jenkins
This commit is contained in:
Russell Bryant 2013-07-08 08:29:24 -04:00 committed by Jenkins
parent a2085f2ab0
commit 094c1d2389
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
openreviews.py
View File

@ -77,8 +77,11 @@ def number_waiting_more_than(changes, seconds, key='age'):
return 0
def gen_stats(projects, waiting_on_reviewer, waiting_on_submitter,
age_sorted, age2_sorted, age3_sorted, options):
def gen_stats(projects, waiting_on_reviewer, waiting_on_submitter, options):
age_sorted = sorted(waiting_on_reviewer, key=lambda change: change['age'])
age2_sorted = sorted(waiting_on_reviewer, key=lambda change: change['age2'])
age3_sorted = sorted(waiting_on_reviewer, key=lambda change: change['age3'])
result = []
result.append(('Projects', '%s' % [project['name']
for project in projects]))
@ -276,14 +279,8 @@ def main(argv=None):
else:
waiting_on_submitter.append(change)
age_sorted = sorted(waiting_on_reviewer, key=lambda change: change['age'])
age2_sorted = sorted(waiting_on_reviewer, key=lambda change: change['age2'])
age3_sorted = sorted(waiting_on_reviewer, key=lambda change: change['age3'])
stats = gen_stats(projects, waiting_on_reviewer, waiting_on_submitter,
age_sorted, age2_sorted, age3_sorted, options)
options)
if options.html:
print_stats_html(stats)