From 67b5119896c50032542f9d4d70cb47bd75e1833b Mon Sep 17 00:00:00 2001 From: Tony Breeds Date: Wed, 6 Apr 2016 14:11:35 +1000 Subject: [PATCH] Filter out members without usernames It seems some groups (eg trove-stable-maint) contain members that lack a 'username' attribute. This causes reviewstats to stack trace. Fix that by filtering out these problematic users. Change-Id: I5b5dd602a7ccf8be56e8227a3037f7d426087a06 --- reviewstats/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reviewstats/utils.py b/reviewstats/utils.py index 54502af..d0ce068 100644 --- a/reviewstats/utils.py +++ b/reviewstats/utils.py @@ -334,7 +334,7 @@ def get_team_members(team_name, server, user, pw): text = requests.get('http://%s/a/groups/%s/detail' % (server, teams[team_name]['id']), auth=auth).text team = json.loads(text[text.find('{'):]) - members_list = [n['username'] for n in team['members']] + members_list = [n['username'] for n in team['members'] if 'username' in n] if 'hudson-openstack' in members_list: # This is a review.openstack.org specific hack. This user is # automatically included in core teams, but we don't want to include it