From 9022c2d416de0c360a40c77e4a25375c02077366 Mon Sep 17 00:00:00 2001 From: Joe Gordon Date: Wed, 10 Jul 2013 10:14:54 +0100 Subject: [PATCH] openapproved: ignore patches with a negative VRIF In addition to ignoring patches with a negative review, ignore patches that fail jenkins tests. As a negative VRIF implies the patch isn't ready to be approved again. Clarify docstring, to point trying to identify trivial rebases only. Change-Id: I812ad787cf6aa06d1ea05b2a0b70574b907b8777 Reviewed-on: https://review.openstack.org/36416 Approved: Russell Bryant Reviewed-by: Russell Bryant Tested-by: Jenkins --- openapproved.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/openapproved.py b/openapproved.py index 89cd032..57b09f4 100755 --- a/openapproved.py +++ b/openapproved.py @@ -16,10 +16,10 @@ # License for the specific language governing permissions and limitations # under the License. -"""Identify approved and open patches. +"""Identify approved and open patches, that are probably just trivial rebases. Prints out list of approved patches that failed to merge and are currently -still open. +still open. Only show patches that are likely to be trivial rebases. """ import optparse @@ -75,7 +75,7 @@ def main(argv=None): def has_negative_feedback(patch_set): approvals = patch_set.get('approvals', []) for review in approvals: - if review['type'] == 'CRVW' and review['value'] in ('-1', '-2'): + if review['type'] in ('CRVW','VRIF') and review['value'] in ('-1', '-2'): return True return False