Commit Graph

224 Commits (7ad92d8088df37a368307eb1fe532d55307866d9)

Author SHA1 Message Date
Russell Bryant 7ad92d8088 Fix CSV output
A previous commit that removed the 'received reviews' from the default
output totally broke CSV output.  This gets it working again.

Change-Id: I76775c496b5b450332f0e8f9d6fa4f7383ffc630
2013-12-04 17:41:23 -05:00
Russell Bryant 3f6e977d87 Fix pep8 tests
We're now gating on pep8, so make it pass.  This removes a couple of
unused imports and fixes a typo in the CSV output code in the reviewers
command.

Change-Id: If77a18497b0efb48f59c10c0e4f5e8b3a8db5a7d
2013-12-04 11:26:16 -05:00
Russell Bryant 710d884bf3 Add barbican.json project file
Change-Id: I0f6b3cd986a9bc5c5b0199069a253b93ee5ed60f
2013-12-02 11:37:14 -05:00
Jenkins f470c1284b Merge "E128 really isn't sane." 2013-12-02 13:10:51 +00:00
Russell Bryant 1416f45759 Fix count of reviewers
The list of reviewers in the code actually includes people that didn't
do any reviews, but received them.  Since tracking received reviews,
this value became inaccurate.

Change-Id: I04c0793823e1371e5b2215c092c8bed4e7ce118f
2013-11-28 08:59:48 -05:00
Robert Collins 4e4e5cb094 E128 really isn't sane.
Change-Id: If8492fdc61a756f2c39b3b560e8b7c174d755f2d
2013-11-28 01:44:58 +00:00
Jenkins 44df331029 Merge "Remove received reviews from output." 2013-11-28 00:46:09 +00:00
Russell Bryant 36402ae486 Remove received reviews from output.
Remove the number of reviews received from the reviewers report output.
I think this information is valuable, but the values we're getting are
not accurate.  The problem is that if a patch gets rebased, the trivial
rebase detection will automatically re-apply reviews.  Those are getting
counted even though they aren't new reviews being received.

Change-Id: I3f1c620c225c1d1d3f2a137b095bac847a353238
2013-11-27 19:27:37 -05:00
Russell Bryant 12029eec6b Add mriedem and dan-prince to nova-core
Change-Id: Iba7131313b46ce6cf409acf414027bc40ac6b964
2013-11-27 11:07:04 -05:00
Russell Bryant 5305d95465 Reformat nova.json
Change the formatting of nova.json so that it isn't all on one long
line.  Also alphabetize the reviewers list.

Change-Id: I37dc9b129d2b28ed0df12399e743a4e3c4849740
2013-11-27 11:05:01 -05:00
Jenkins 4ed170cb11 Merge "Document the JSON schema a little." 2013-11-27 15:39:37 +00:00
Jenkins 8618a393f5 Merge "Remove unused import in reviews_for_bugs." 2013-11-27 15:39:15 +00:00
Jenkins 2f8148494b Merge "Fix importing of utils in two scripts." 2013-11-27 15:38:52 +00:00
Matthew Treinish fb5d1c0af1 Update tempest core group
There were some recent changes to the tempest core group, this commit
updates the group listing to reflect that.

Change-Id: I64da04d3ad85a1d6869b62a8943a0746a1dcccb7
2013-11-27 09:37:02 -05:00
Robert Collins a2b96dffc2 Document the JSON schema a little.
Change-Id: I804a6d347abf297b3ea84be3dbdf2748e18f4aa5
2013-11-27 03:14:55 +00:00
Robert Collins 20f4401d0d Remove unused import in reviews_for_bugs.
Change-Id: I9fbeafe8badc30dea606f63622f80b4713570307
2013-11-27 03:10:48 +00:00
Robert Collins 1ab27d9d99 Fix importing of utils in two scripts.
Ooops.

Change-Id: I8e40d64ae107d4269d83d6b004ddfb8c0ac0219b
2013-11-27 03:07:30 +00:00
Robert Collins 839f970377 Move reviewers.py into the reviewstats namespace.
Change-Id: I962cd777cb3507d26fd146f553236f7c6e9af772
2013-11-25 11:18:12 -05:00
Robert Collins 1b1c2dad6f Move openreviews into the reviewstats namespace.
Change-Id: I3029a4568c74b227412b677fcb5e6df6c040458f
2013-11-25 11:18:12 -05:00
Robert Collins e6d1ca533e Move reviews_for_bugs into reviewstats.
Change-Id: I4584b1fed09b0e10f144b9110457436dd04d601d
2013-11-25 11:18:12 -05:00
Robert Collins 3e09039c02 Move openapproved into the reviewstats namespace.
This involves updating one of the shell scripts which now depends on
'pip install -e .' or 'pip install reviewstats' (for a release) having
been run.

Change-Id: I2e63501c4a41ed0b20b1ab7ba1e2f78beed04962
2013-11-25 11:18:12 -05:00
Robert Collins df820e42a5 Basic usage instructions.
Change-Id: Ifaa90d243fa2996e8c16682a9f4d0b3c423b8159
2013-11-25 11:18:04 -05:00
Robert Collins 622f67695c Move utils into the reviewstats namespace.
Change-Id: I1b8418d7e0885d963df32f4c718855d2e989107d
2013-11-25 07:00:16 +00:00
Robert Collins 44fdb1f2c4 Move tests into the setuptools structure.
Change-Id: I0bcdc59b9c23270b0742c3772ef01aaa73893bcd
2013-11-25 06:56:31 +00:00
Robert Collins 3bee82ad3f Ignore E126.
Change-Id: I61abeba1dc987569e23bbfb5ab45c55e42916313
2013-11-25 03:27:30 +00:00
Robert Collins 98d4a78c16 Cookiecutterify reviewstats.
One step on a long path. Note that there is some noddy stuff in here
like a pointless test - its in cookiecutter and I don't want to muddle
code moves up with that, so 'meh'.

Change-Id: I500b92c0e8177c85e696d039417dcf982010775b
2013-11-25 03:26:57 +00:00
Robert Collins 56cc948e8e Tweak formatting for hacking.
I'm about to bring in regular project infrastructure, this is a
prelude to that.

Change-Id: I58031c196ee4105a4f51c99bf7a9ad3a29d84c6b
2013-11-25 03:26:42 +00:00
Russell Bryant 19b0841eb1 Fix disagreement percentage calculation
Previously, a disagreement was defined as a core reviewer giving a
negative vote after the person had given a positive vote.  The
percentage was then the number of disagreements / all positive votes.

Later, disagreements were extended to cover the opposite case: when a
core member gives a positive vote after a person had given a negative
vote.

The percentage calculation was not updated to reflect this new
definition.  It still showed disagreements as a percentage of the
positive votes, instead of all of them (+ and -).

Change-Id: I6392055e5d95dfece86cdd427f44e258566e771a
2013-11-21 01:34:36 -05:00
Jenkins 4e7cc8666e Merge "Add jenkins-job-builder as a broken out project" 2013-11-19 19:27:19 +00:00
Monty Taylor 0f71ba790e Add jenkins-job-builder as a broken out project
There is a wholly separate dev community around jenkins-job-builder
that it would be nice to track. Leaving jjb also in infra though,
because it's interesting to track there as well.

Change-Id: I61f29f78bb6300f9b0c9fe9522172f090234f0b9
2013-11-20 07:29:01 +13:00
Zane Bitter 9453db9b83 Add randall-burt to heat-core
http://lists.openstack.org/pipermail/openstack-dev/2013-October/017782.html

Change-Id: I1e753898fba5ad6dfdbfc62842228e29810e7e58
2013-11-19 13:32:34 +01:00
Brant Knudson 022a0836ca Morgan Fainberg is Keystone core
mdrnstm was not listed as a Keystone core member.

Change-Id: I014bd9b9d74053705fdceaf45f4c5e08928bfc3e
2013-11-17 21:50:02 -06:00
Sergey Lukjanov 563eb0dde0 Add storyboard project
Change-Id: I6fd7c726b32d06bdb31aaef6209af5a4ff20f810
2013-11-18 12:42:00 -05:00
Jenkins 8c8ca50cee Merge "Add python-solumclient subproject" 2013-11-18 02:06:17 +00:00
Noorul Islam K M 56dbaa602d Add python-solumclient subproject
Change-Id: Ief3d97c84a8ba766a10149cff630476c5150689f
2013-11-18 05:12:40 +05:30
Jenkins 2a9bdc47ae Merge "Add rubick project tracking" 2013-11-17 23:22:13 +00:00
Noorul Islam K M 5a4c6f98b5 Add rubick project tracking
Change-Id: I663203c5879cb536cbb3a97d91a2e0346b7a9af1
2013-11-17 10:21:37 +05:30
Noorul Islam K M 1438ec43ed Add new core reviewers
Change-Id: I729beaaf944e0c82a0248105606ac138bc9536f7
2013-11-17 09:51:12 +05:30
Jenkins 0766a59ccc Merge "Adds new/merge rate to reviewers information" 2013-11-15 23:48:39 +00:00
Chris Yeoh 9560da6a40 Adds new/merge rate to reviewers information
Adds more per day stats:
  - Changes with at least one patchset active in the time period
  - New changes uploaded
  - Changes merged
  - Changes abandoned
  - Changes left in WIP
Estimation of queue growth based over the time period

Change-Id: Idbedc70c19db215e627e047785238c5dc94fd4ea
2013-11-15 10:43:28 +10:30
Russell Bryant 07007bfdf1 Show average reviews per day
Show average reviews per day across all reviewers as well as across the
core review teams.

Change-Id: I73cb6359d4f256c097c555b9b79d375042877cb7
2013-11-14 12:08:24 -05:00
Russell Bryant 10cc472d0f Fix core member count
Fix the core member count to actually work when generating a report for
multiple projects (such as all projects).

Change-Id: Ib846c5e5d42478505bd622c0f7adf105c300ed13
2013-11-14 11:57:01 -05:00
Russell Bryant 29d3e5d8d5 Fix rendering issue
The infinity symbol doesn't seem to be rendering properly for people, so
simplify by just using 'inf' instead.

Change-Id: I5baac086222f90d02b5c4541618d1a802367d833
2013-11-14 10:33:51 -05:00
Jenkins 84c977acc5 Merge "Add some per day stats" 2013-11-13 23:09:40 +00:00
Jenkins 9235912b79 Merge "Add received reviews to review stats" 2013-11-13 23:08:54 +00:00
Jenkins 176a4172f5 Merge "Show how many patch sets were created" 2013-11-13 23:07:38 +00:00
Fei Long Wang b5e5204749 Add new core member for Glance
Change-Id: I56a29a4bc623b17e6d62782ca4202a81e19d5097
2013-11-13 23:04:39 +08:00
Russell Bryant 2b29d1b707 Add some per day stats
Show the number per day of
 - reviews
 - reviews by core team
 - patch sets created

Change-Id: I9203828e18f126c3f70c8cf7c3914b9826ed44e8
2013-11-13 06:59:53 -05:00
Russell Bryant 4f6b51bbb0 Add received reviews to review stats
Add a new column that shows how many reviews each person received in the
same time frame.  It also shows the ratio between reviews given and
received.

As a side effect, the result now also includes those that submitted
patches but did no reviews.  I think that's still useful information to
show when looking at the heath of the review queue.

Change-Id: I936c65c91a76c3de6872da0f53a1fa10e3ca111e
2013-11-13 05:32:00 -05:00
Robert Collins fa09fed2a5 Add TOCI as a TripleO review responsibility.
Change-Id: I9bc9665b5d91c49e0ffe722c46b8589b90b692f1
2013-11-13 16:04:16 +13:00