reviewstats/7be58d6af84f44c4f6eb9a26ccf...

75 lines
2.1 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "bf51134e_78a86876",
"filename": "tox.ini",
"patchSetId": 6
},
"lineNbr": 14,
"author": {
"id": 1736
},
"writtenOn": "2020-06-19T19:08:02Z",
"side": 0,
"message": "Do we need to remove these lines too?",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 14,
"endChar": 23
},
"revId": "7be58d6af84f44c4f6eb9a26ccfc2be253b94a8d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bf51134e_f8ed988b",
"filename": "tox.ini",
"patchSetId": 6
},
"lineNbr": 14,
"author": {
"id": 11904
},
"writtenOn": "2020-06-19T19:25:51Z",
"side": 0,
"message": "If I understand this correct, this is just a redundant statement. The {envdir} would refer to the virtual environment (so something like .tox/pep), which is automatically set by tox to the virtual environment. tox activates the environment, which would set the VIRTUAL_ENV variable. So this isn\u0027t really needed.",
"parentUuid": "bf51134e_78a86876",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 14,
"endChar": 23
},
"revId": "7be58d6af84f44c4f6eb9a26ccfc2be253b94a8d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bf51134e_7855081d",
"filename": "tox.ini",
"patchSetId": 6
},
"lineNbr": 14,
"author": {
"id": 1736
},
"writtenOn": "2020-06-19T19:31:38Z",
"side": 0,
"message": "Thanks for the explanation, Sean.",
"parentUuid": "bf51134e_f8ed988b",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 14,
"endChar": 23
},
"revId": "7be58d6af84f44c4f6eb9a26ccfc2be253b94a8d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}