Merge "Formating success and fail messages for flows."

This commit is contained in:
Jenkins 2013-07-04 13:05:43 +00:00 committed by Gerrit Code Review
commit 92c9a55587
7 changed files with 29 additions and 9 deletions

View File

@ -27,6 +27,8 @@ LOG = logging.getLogger(__name__)
class CopyClusterTemplate(create_flow.ConfigureClusterTemplate): class CopyClusterTemplate(create_flow.ConfigureClusterTemplate):
success_message = _("Cluster Template copy %s created")
failure_message = _("Could not create Cluster Template copy %s")
def __init__(self, request, context_seed, entry_point, *args, **kwargs): def __init__(self, request, context_seed, entry_point, *args, **kwargs):
savanna = savannaclient.Client(request) savanna = savannaclient.Client(request)

View File

@ -227,8 +227,8 @@ class ConfigureClusterTemplate(whelpers.ServiceParametersWorkflow):
slug = "configure_cluster_template" slug = "configure_cluster_template"
name = _("Create Cluster Template") name = _("Create Cluster Template")
finalize_button_name = _("Create") finalize_button_name = _("Create")
success_message = _("Created") success_message = _("Created Cluster Template %s")
failure_message = _("Could not create") failure_message = _("Could not create Cluster Template %s")
success_url = "horizon:savanna:cluster_templates:index" success_url = "horizon:savanna:cluster_templates:index"
default_steps = (GeneralConfig, default_steps = (GeneralConfig,
ConfigureNodegroups) ConfigureNodegroups)
@ -270,6 +270,9 @@ class ConfigureClusterTemplate(whelpers.ServiceParametersWorkflow):
return steps_valid return steps_valid
return self.validate(self.context) return self.validate(self.context)
def format_status_message(self, message):
return message % self.context["general_cluster_template_name"]
def handle(self, request, context): def handle(self, request, context):
try: try:
savanna = savannaclient.Client(request) savanna = savannaclient.Client(request)

View File

@ -36,7 +36,7 @@ class CreateCluster(tables.LinkAction):
class DeleteCluster(tables.BatchAction): class DeleteCluster(tables.BatchAction):
name = "delete" name = "delete"
action_present = _("Delete") action_present = _("Delete")
action_past = _("Delete cluster of") action_past = _("Deleted")
data_type_singular = _("Cluster") data_type_singular = _("Cluster")
data_type_plural = _("Clusters") data_type_plural = _("Clusters")
classes = ('btn-danger', 'btn-terminate') classes = ('btn-danger', 'btn-terminate')

View File

@ -159,8 +159,8 @@ class ConfigureCluster(workflows.Workflow):
slug = "configure_cluster" slug = "configure_cluster"
name = _("Launch Cluster") name = _("Launch Cluster")
finalize_button_name = _("Create") finalize_button_name = _("Create")
success_message = _("Created") success_message = _("Created Cluster %s")
failure_message = _("Could not create") failure_message = _("Could not create Cluster %s")
success_url = "horizon:savanna:clusters:index" success_url = "horizon:savanna:clusters:index"
default_steps = (GeneralConfig, ) default_steps = (GeneralConfig, )
@ -183,6 +183,9 @@ class ConfigureCluster(workflows.Workflow):
return steps_valid return steps_valid
return self.validate(self.context) return self.validate(self.context)
def format_status_message(self, message):
return message % self.context["general_cluster_name"]
def handle(self, request, context): def handle(self, request, context):
try: try:
savanna = savannaclient.Client(request) savanna = savannaclient.Client(request)

View File

@ -15,10 +15,12 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
import json
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from horizon import exceptions from horizon import exceptions
from horizon import forms from horizon import forms
import json from horizon import messages
from savannadashboard.api import client as savannaclient from savannadashboard.api import client as savannaclient
from savannadashboard.utils import importutils from savannadashboard.utils import importutils
@ -50,6 +52,8 @@ class ImageForm(forms.SelfHandlingForm):
image_tags = json.loads(data["tags_list"]) image_tags = json.loads(data["tags_list"])
savanna.images.update_tags(image_id, image_tags) savanna.images.update_tags(image_id, image_tags)
messages.success(request, self.message)
return True return True
except Exception: except Exception:
exceptions.handle(request) exceptions.handle(request)
@ -57,10 +61,12 @@ class ImageForm(forms.SelfHandlingForm):
class EditTagsForm(ImageForm): class EditTagsForm(ImageForm):
message = "Image updated."
image_id = forms.CharField(widget=forms.HiddenInput()) image_id = forms.CharField(widget=forms.HiddenInput())
class RegisterImageForm(ImageForm): class RegisterImageForm(ImageForm):
message = "Image registered."
image_id = forms.ChoiceField(label=_("Image"), image_id = forms.ChoiceField(label=_("Image"),
required=True) required=True)

View File

@ -17,14 +17,17 @@
import logging import logging
from savannadashboard.api import client as savannaclient from django.utils.translation import ugettext as _
from savannadashboard.api import client as savannaclient
import savannadashboard.nodegroup_templates.workflows.create as create_flow import savannadashboard.nodegroup_templates.workflows.create as create_flow
LOG = logging.getLogger(__name__) LOG = logging.getLogger(__name__)
class CopyNodegroupTemplate(create_flow.ConfigureNodegroupTemplate): class CopyNodegroupTemplate(create_flow.ConfigureNodegroupTemplate):
success_message = _("Node Group Template copy %s created")
failure_message = _("Could not copy Node Group Template %s")
def __init__(self, request, context_seed, entry_point, *args, **kwargs): def __init__(self, request, context_seed, entry_point, *args, **kwargs):
savanna = savannaclient.Client(request) savanna = savannaclient.Client(request)

View File

@ -157,8 +157,8 @@ class ConfigureNodegroupTemplate(whelpers.ServiceParametersWorkflow):
slug = "configure_nodegroup_template" slug = "configure_nodegroup_template"
name = _("Create Node Group Template") name = _("Create Node Group Template")
finalize_button_name = _("Create") finalize_button_name = _("Create")
success_message = _("Created") success_message = _("Created Node Group Template %s")
failure_message = _("Could not create") failure_message = _("Could not create Node Group Template %s")
success_url = "horizon:savanna:nodegroup_templates:index" success_url = "horizon:savanna:nodegroup_templates:index"
default_steps = (GeneralConfig,) default_steps = (GeneralConfig,)
@ -183,6 +183,9 @@ class ConfigureNodegroupTemplate(whelpers.ServiceParametersWorkflow):
entry_point, entry_point,
*args, **kwargs) *args, **kwargs)
def format_status_message(self, message):
return message % self.context["general_nodegroup_name"]
def is_valid(self): def is_valid(self):
missing = self.depends_on - set(self.context.keys()) missing = self.depends_on - set(self.context.keys())
if missing: if missing: