From 2fb2422da81f6ece47e626fc4d77bf5931931445 Mon Sep 17 00:00:00 2001
From: Pino Toscano <ptoscano@redhat.com>
Date: Tue, 7 Apr 2015 10:36:42 +0200
Subject: [PATCH] Make almost all the element scripts as e/u/pipefail

Following the latest dib-lint reporting, make sure almost all the
scripts are enabling -e, -u, and pipefail.  This eases the discovery of
failing commands, and the usage of unset variables.

There are few exceptions with flags not set:

* elements/hadoop-hdp/install.d/40-install-hdp, set -e
  when installing HDP 2.0, it tries to install tez, which does not seem
  to exist in Hortonworks' repositories

* elements/ssh/install.d/33-ssh, set -e
  the version of augtool (part of augeas 0.10) in older Ubuntu versions
  (like Precise, needed by the cloudera plugin) exits with wrong return
  values in autosave mode

* elements/storm/install.d/60-storm, set -e
  It tries to change the permission of /etc/supervisord.conf, which does
  not seem to exist

Change-Id: Ic1314639dfc6a66c48ca87b6820707a2b0cb1dbd
Partial-Bug: #1435306
---
 elements/apt-mirror/finalise.d/99-setup                        | 2 ++
 elements/apt-mirror/pre-install.d/00-apt                       | 2 ++
 elements/apt-mirror/root.d/0-check                             | 2 ++
 elements/centos-mirror/finalise.d/99-setup                     | 2 ++
 elements/centos-mirror/pre-install.d/00-yum                    | 2 ++
 elements/centos-mirror/root.d/0-check                          | 2 ++
 elements/disable-firewall/post-install.d/30-disable-firewalld  | 2 ++
 elements/disable-firewall/post-install.d/31-disable-ip6tables  | 3 ++-
 elements/disable-firewall/post-install.d/32-disable-iptables   | 3 ++-
 elements/fedora-mirror/finalise.d/99-setup                     | 2 ++
 elements/fedora-mirror/pre-install.d/00-yum                    | 2 ++
 elements/fedora-mirror/root.d/0-check                          | 2 ++
 elements/hadoop-cdh/post-install.d/40-setup-hadoop             | 2 ++
 elements/hadoop-cdh/post-install.d/50-cdh-fixes                | 2 ++
 elements/hadoop-cdh/root.d/0-check-hadoop-cdh                  | 3 ++-
 elements/hadoop-cloudera/install.d/50-install-cloudera         | 1 +
 elements/hadoop-cloudera/install.d/60-install-extjs            | 3 ++-
 elements/hadoop-cloudera/post-install.d/70-turn-services-off   | 1 +
 elements/hadoop-cloudera/pre-install.d/10-add-mirror           | 2 ++
 elements/hadoop-hdp/install.d/20-nozeroconf                    | 2 ++
 elements/hadoop-hdp/install.d/30-init-hdp-install              | 2 ++
 elements/hadoop-hdp/install.d/40-install-hdp                   | 2 ++
 elements/hadoop-hdp/post-install.d/10-disable-repos            | 2 ++
 elements/hadoop-hdp/post-install.d/20-cleanup                  | 2 ++
 elements/hadoop-hdp/post-install.d/40-turn-off-gmetad          | 2 ++
 elements/hadoop-hdp/post-install.d/50-turn-on-ntpd             | 2 ++
 elements/hadoop-hdp/post-install.d/55-turn-off-ambari-services | 2 ++
 .../hadoop-hdp/post-install.d/58-turn-off-hadoop-2-services    | 2 ++
 elements/hadoop-hdp/post-install.d/60-enable-local-hdp-repos   | 2 ++
 elements/hadoop-mapr/install.d/40-mapr-dependencies            | 1 +
 elements/hadoop-mapr/install.d/41-scala                        | 1 +
 elements/hadoop-mapr/install.d/42-versions                     | 1 +
 elements/hadoop-mapr/install.d/43-mapr-core-repository         | 1 +
 elements/hadoop-mapr/install.d/44-mapr-eco-repository          | 1 +
 elements/hadoop-mapr/install.d/44-oozie-libs                   | 1 +
 elements/hadoop-mapr/post-install.d/99-requiretty              | 1 +
 elements/hadoop-mapr/post-install.d/99-update-repository       | 1 +
 elements/hadoop-mapr/root.d/0-mapr-check-version               | 1 +
 elements/hadoop/post-install.d/40-setup-hadoop                 | 2 ++
 elements/hadoop/root.d/0-check-hadoop                          | 3 ++-
 elements/hive/post-install.d/60-hive                           | 2 ++
 elements/hive/root.d/0-check-hive                              | 2 ++
 elements/java/cleanup.d/00-clean-java-vars                     | 1 +
 elements/mysql/install.d/10-mysql                              | 3 ++-
 elements/mysql/install.d/99-disable-mysql-on-boot              | 2 ++
 elements/oozie/install.d/50-setup-oozie                        | 2 ++
 elements/oozie/post-install.d/90-oozie-war                     | 2 ++
 elements/oozie/root.d/0-check-oozie                            | 3 ++-
 elements/oracle-java/install.d/33-java                         | 3 ++-
 elements/redhat-lsb/pre-install.d/02-lsb                       | 2 ++
 elements/root-passwd/post-install.d/99-setup                   | 2 ++
 elements/sahara-version/install.d/01-sahara-version            | 2 ++
 elements/spark/install.d/60-spark                              | 2 ++
 elements/spark/post-install.d/20-spark                         | 2 ++
 elements/spark/root.d/0-check-spark                            | 2 ++
 elements/ssh/install.d/33-ssh                                  | 2 ++
 elements/storm/install.d/60-storm                              | 2 ++
 elements/storm/root.d/0-check-storm                            | 2 ++
 elements/swift_hadoop/post-install.d/81-add-jar                | 2 ++
 elements/updater/install.d/00-updater                          | 2 ++
 elements/zookeeper/install.d/40-zookeeper                      | 2 ++
 elements/zookeeper/post-install.d/50-zookeeper                 | 2 ++
 62 files changed, 112 insertions(+), 8 deletions(-)

diff --git a/elements/apt-mirror/finalise.d/99-setup b/elements/apt-mirror/finalise.d/99-setup
index 5fcd3800..91ce9815 100755
--- a/elements/apt-mirror/finalise.d/99-setup
+++ b/elements/apt-mirror/finalise.d/99-setup
@@ -3,5 +3,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 rm /etc/apt/apt.conf.d/01proxy
diff --git a/elements/apt-mirror/pre-install.d/00-apt b/elements/apt-mirror/pre-install.d/00-apt
index d45393fb..e73d437d 100755
--- a/elements/apt-mirror/pre-install.d/00-apt
+++ b/elements/apt-mirror/pre-install.d/00-apt
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 mkdir -p /etc/apt/apt.conf.d/
 touch /etc/apt/apt.conf.d/01proxy
diff --git a/elements/apt-mirror/root.d/0-check b/elements/apt-mirror/root.d/0-check
index ae498b82..a87746e1 100755
--- a/elements/apt-mirror/root.d/0-check
+++ b/elements/apt-mirror/root.d/0-check
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 if [ -z "$UBUNTU_MIRROR" ]; then
     echo "You should specify parameter 'UBUNTU_MIRROR'"
diff --git a/elements/centos-mirror/finalise.d/99-setup b/elements/centos-mirror/finalise.d/99-setup
index eeb9b09c..bbc84deb 100755
--- a/elements/centos-mirror/finalise.d/99-setup
+++ b/elements/centos-mirror/finalise.d/99-setup
@@ -3,5 +3,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 mv /opt/repos/* /etc/yum.repos.d/
diff --git a/elements/centos-mirror/pre-install.d/00-yum b/elements/centos-mirror/pre-install.d/00-yum
index 2893eb82..ef658883 100755
--- a/elements/centos-mirror/pre-install.d/00-yum
+++ b/elements/centos-mirror/pre-install.d/00-yum
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 mkdir -p /opt/repos
 mv /etc/yum.repos.d/* /opt/repos/
diff --git a/elements/centos-mirror/root.d/0-check b/elements/centos-mirror/root.d/0-check
index ae1364a1..299d51ef 100755
--- a/elements/centos-mirror/root.d/0-check
+++ b/elements/centos-mirror/root.d/0-check
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 if [ -z "$CENTOS_MIRROR" ]; then
     echo "You should specify parameter 'CENTOS_MIRROR'"
diff --git a/elements/disable-firewall/post-install.d/30-disable-firewalld b/elements/disable-firewall/post-install.d/30-disable-firewalld
index 9c7d41f6..daad8711 100755
--- a/elements/disable-firewall/post-install.d/30-disable-firewalld
+++ b/elements/disable-firewall/post-install.d/30-disable-firewalld
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 install-packages which
 
diff --git a/elements/disable-firewall/post-install.d/31-disable-ip6tables b/elements/disable-firewall/post-install.d/31-disable-ip6tables
index b8ca7bb8..b28f5ff9 100755
--- a/elements/disable-firewall/post-install.d/31-disable-ip6tables
+++ b/elements/disable-firewall/post-install.d/31-disable-ip6tables
@@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
-set -e
+set -eu
+set -o pipefail
 
 if [ "$DISTRO_NAME" = "fedora" ]; then
     install-packages iptables-services
diff --git a/elements/disable-firewall/post-install.d/32-disable-iptables b/elements/disable-firewall/post-install.d/32-disable-iptables
index fb9c6729..9d33634d 100755
--- a/elements/disable-firewall/post-install.d/32-disable-iptables
+++ b/elements/disable-firewall/post-install.d/32-disable-iptables
@@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
-set -e
+set -eu
+set -o pipefail
 
 if [ "$DISTRO_NAME" = "fedora" ]; then
     install-packages iptables-services
diff --git a/elements/fedora-mirror/finalise.d/99-setup b/elements/fedora-mirror/finalise.d/99-setup
index eeb9b09c..bbc84deb 100755
--- a/elements/fedora-mirror/finalise.d/99-setup
+++ b/elements/fedora-mirror/finalise.d/99-setup
@@ -3,5 +3,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 mv /opt/repos/* /etc/yum.repos.d/
diff --git a/elements/fedora-mirror/pre-install.d/00-yum b/elements/fedora-mirror/pre-install.d/00-yum
index 4a591288..888d7026 100755
--- a/elements/fedora-mirror/pre-install.d/00-yum
+++ b/elements/fedora-mirror/pre-install.d/00-yum
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 mkdir -p /opt/repos
 mv /etc/yum.repos.d/* /opt/repos
diff --git a/elements/fedora-mirror/root.d/0-check b/elements/fedora-mirror/root.d/0-check
index 004ae374..3c4cda25 100755
--- a/elements/fedora-mirror/root.d/0-check
+++ b/elements/fedora-mirror/root.d/0-check
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 if [ -z "$FEDORA_MIRROR" ]; then
     echo "You should specify parameter 'FEDORA_MIRROR'"
diff --git a/elements/hadoop-cdh/post-install.d/40-setup-hadoop b/elements/hadoop-cdh/post-install.d/40-setup-hadoop
index f6c97e22..1daeb752 100755
--- a/elements/hadoop-cdh/post-install.d/40-setup-hadoop
+++ b/elements/hadoop-cdh/post-install.d/40-setup-hadoop
@@ -7,6 +7,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 if [ "$DISTRO_NAME" != "ubuntu" ]; then
     echo "Distro $DISTRO_NAME not supported by CDH. Exiting."
diff --git a/elements/hadoop-cdh/post-install.d/50-cdh-fixes b/elements/hadoop-cdh/post-install.d/50-cdh-fixes
index 9a920dbe..cd27c1fd 100755
--- a/elements/hadoop-cdh/post-install.d/50-cdh-fixes
+++ b/elements/hadoop-cdh/post-install.d/50-cdh-fixes
@@ -6,6 +6,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 case "$DISTRO_NAME" in
     ubuntu )
diff --git a/elements/hadoop-cdh/root.d/0-check-hadoop-cdh b/elements/hadoop-cdh/root.d/0-check-hadoop-cdh
index d22ef3b3..70632624 100755
--- a/elements/hadoop-cdh/root.d/0-check-hadoop-cdh
+++ b/elements/hadoop-cdh/root.d/0-check-hadoop-cdh
@@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
-set -e
+set -eu
+set -o pipefail
 
 if [ -z "$JAVA_DOWNLOAD_URL" ]; then
     if [ -z "$JAVA_FILE" ]; then
diff --git a/elements/hadoop-cloudera/install.d/50-install-cloudera b/elements/hadoop-cloudera/install.d/50-install-cloudera
index c91f9d96..98f00c29 100755
--- a/elements/hadoop-cloudera/install.d/50-install-cloudera
+++ b/elements/hadoop-cloudera/install.d/50-install-cloudera
@@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
 set -eu
+set -o pipefail
 
 if [ "$DISTRO_NAME" = "ubuntu" ]; then
     export DEBIAN_FRONTEND=noninteractive
diff --git a/elements/hadoop-cloudera/install.d/60-install-extjs b/elements/hadoop-cloudera/install.d/60-install-extjs
index 0f660e2b..ca4c928d 100755
--- a/elements/hadoop-cloudera/install.d/60-install-extjs
+++ b/elements/hadoop-cloudera/install.d/60-install-extjs
@@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
-set -e
+set -eu
+set -o pipefail
 
 install-packages wget unzip
 
diff --git a/elements/hadoop-cloudera/post-install.d/70-turn-services-off b/elements/hadoop-cloudera/post-install.d/70-turn-services-off
index fa49e0b8..62e2874b 100755
--- a/elements/hadoop-cloudera/post-install.d/70-turn-services-off
+++ b/elements/hadoop-cloudera/post-install.d/70-turn-services-off
@@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
 set -eu
+set -o pipefail
 
 for i in cloudera-scm-agent \
 cloudera-scm-server \
diff --git a/elements/hadoop-cloudera/pre-install.d/10-add-mirror b/elements/hadoop-cloudera/pre-install.d/10-add-mirror
index 19bbddc3..04f5ccd2 100755
--- a/elements/hadoop-cloudera/pre-install.d/10-add-mirror
+++ b/elements/hadoop-cloudera/pre-install.d/10-add-mirror
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 function add_repo_5_0_0 {
     case $DISTRO_NAME in
diff --git a/elements/hadoop-hdp/install.d/20-nozeroconf b/elements/hadoop-hdp/install.d/20-nozeroconf
index 49231937..8865676b 100755
--- a/elements/hadoop-hdp/install.d/20-nozeroconf
+++ b/elements/hadoop-hdp/install.d/20-nozeroconf
@@ -25,5 +25,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 echo "NOZEROCONF=yes" >> /etc/sysconfig/network
diff --git a/elements/hadoop-hdp/install.d/30-init-hdp-install b/elements/hadoop-hdp/install.d/30-init-hdp-install
index 29eaa021..d6875071 100755
--- a/elements/hadoop-hdp/install.d/30-init-hdp-install
+++ b/elements/hadoop-hdp/install.d/30-init-hdp-install
@@ -23,6 +23,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 install-packages wget
 install-packages ntp
diff --git a/elements/hadoop-hdp/install.d/40-install-hdp b/elements/hadoop-hdp/install.d/40-install-hdp
index 5a76f9dd..84ab05cf 100755
--- a/elements/hadoop-hdp/install.d/40-install-hdp
+++ b/elements/hadoop-hdp/install.d/40-install-hdp
@@ -27,6 +27,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -u
+set -o pipefail
 
 function install_ganglia {
     # Install ganglia
diff --git a/elements/hadoop-hdp/post-install.d/10-disable-repos b/elements/hadoop-hdp/post-install.d/10-disable-repos
index e8f99468..e7521126 100755
--- a/elements/hadoop-hdp/post-install.d/10-disable-repos
+++ b/elements/hadoop-hdp/post-install.d/10-disable-repos
@@ -29,5 +29,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 find /etc/yum.repos.d -name "*.repo" -type f | xargs sed "s/enabled=1/enabled=0/" -i
diff --git a/elements/hadoop-hdp/post-install.d/20-cleanup b/elements/hadoop-hdp/post-install.d/20-cleanup
index f3f9bf34..be0a07b8 100755
--- a/elements/hadoop-hdp/post-install.d/20-cleanup
+++ b/elements/hadoop-hdp/post-install.d/20-cleanup
@@ -23,6 +23,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 # ===== CLEANUP MISC  =====
 rm -rf /var/cache/*
diff --git a/elements/hadoop-hdp/post-install.d/40-turn-off-gmetad b/elements/hadoop-hdp/post-install.d/40-turn-off-gmetad
index 78f51e6f..fbf81469 100755
--- a/elements/hadoop-hdp/post-install.d/40-turn-off-gmetad
+++ b/elements/hadoop-hdp/post-install.d/40-turn-off-gmetad
@@ -24,6 +24,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 # Turn off gmetad
 chkconfig gmetad off
diff --git a/elements/hadoop-hdp/post-install.d/50-turn-on-ntpd b/elements/hadoop-hdp/post-install.d/50-turn-on-ntpd
index 44fddc48..4260dcdd 100755
--- a/elements/hadoop-hdp/post-install.d/50-turn-on-ntpd
+++ b/elements/hadoop-hdp/post-install.d/50-turn-on-ntpd
@@ -24,6 +24,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 # Turn on ntp service
 chkconfig ntpd on
diff --git a/elements/hadoop-hdp/post-install.d/55-turn-off-ambari-services b/elements/hadoop-hdp/post-install.d/55-turn-off-ambari-services
index ac0ce2da..ec418c5b 100755
--- a/elements/hadoop-hdp/post-install.d/55-turn-off-ambari-services
+++ b/elements/hadoop-hdp/post-install.d/55-turn-off-ambari-services
@@ -24,6 +24,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 # Turn off ambari-server service for the first boot of this image
 chkconfig ambari-server off
diff --git a/elements/hadoop-hdp/post-install.d/58-turn-off-hadoop-2-services b/elements/hadoop-hdp/post-install.d/58-turn-off-hadoop-2-services
index 41b7bc46..4ce2d84f 100755
--- a/elements/hadoop-hdp/post-install.d/58-turn-off-hadoop-2-services
+++ b/elements/hadoop-hdp/post-install.d/58-turn-off-hadoop-2-services
@@ -28,6 +28,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 # This is only necessary for an HDP 2.x install
 if [[ $DIB_HDP_VERSION == "2.0"  ]]; then
diff --git a/elements/hadoop-hdp/post-install.d/60-enable-local-hdp-repos b/elements/hadoop-hdp/post-install.d/60-enable-local-hdp-repos
index 08cdd553..d5e855ac 100755
--- a/elements/hadoop-hdp/post-install.d/60-enable-local-hdp-repos
+++ b/elements/hadoop-hdp/post-install.d/60-enable-local-hdp-repos
@@ -25,6 +25,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 # create a new local yum repository definition that
 # includes:
diff --git a/elements/hadoop-mapr/install.d/40-mapr-dependencies b/elements/hadoop-mapr/install.d/40-mapr-dependencies
index fd897f6e..cb46d3aa 100755
--- a/elements/hadoop-mapr/install.d/40-mapr-dependencies
+++ b/elements/hadoop-mapr/install.d/40-mapr-dependencies
@@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
 set -eu
+set -o pipefail
 
 echo "START: installing MapR core dependencies"
 
diff --git a/elements/hadoop-mapr/install.d/41-scala b/elements/hadoop-mapr/install.d/41-scala
index 6cf3b4db..9cc68f32 100755
--- a/elements/hadoop-mapr/install.d/41-scala
+++ b/elements/hadoop-mapr/install.d/41-scala
@@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
 set -eu
+set -o pipefail
 
 echo "START: installing Scala"
 
diff --git a/elements/hadoop-mapr/install.d/42-versions b/elements/hadoop-mapr/install.d/42-versions
index dc8fb2fe..5a233d0d 100755
--- a/elements/hadoop-mapr/install.d/42-versions
+++ b/elements/hadoop-mapr/install.d/42-versions
@@ -4,5 +4,6 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
 set -eu
+set -o pipefail
 
 install -D -g root -o root -m 0644 $(dirname $0)/versions.py /tmp/versions.py
diff --git a/elements/hadoop-mapr/install.d/43-mapr-core-repository b/elements/hadoop-mapr/install.d/43-mapr-core-repository
index 4106905d..c10bcdbc 100755
--- a/elements/hadoop-mapr/install.d/43-mapr-core-repository
+++ b/elements/hadoop-mapr/install.d/43-mapr-core-repository
@@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
 set -eu
+set -o pipefail
 
 echo "START: installing MapR core repository"
 
diff --git a/elements/hadoop-mapr/install.d/44-mapr-eco-repository b/elements/hadoop-mapr/install.d/44-mapr-eco-repository
index 838ccedc..3fd9e44b 100755
--- a/elements/hadoop-mapr/install.d/44-mapr-eco-repository
+++ b/elements/hadoop-mapr/install.d/44-mapr-eco-repository
@@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
 set -eu
+set -o pipefail
 
 echo "START: installing MapR ecosystem repository"
 
diff --git a/elements/hadoop-mapr/install.d/44-oozie-libs b/elements/hadoop-mapr/install.d/44-oozie-libs
index 027886f1..eb23968f 100755
--- a/elements/hadoop-mapr/install.d/44-oozie-libs
+++ b/elements/hadoop-mapr/install.d/44-oozie-libs
@@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
 set -eu
+set -o pipefail
 
 echo "START: downloading ExtJS library"
 
diff --git a/elements/hadoop-mapr/post-install.d/99-requiretty b/elements/hadoop-mapr/post-install.d/99-requiretty
index 2bfcd961..7d721162 100755
--- a/elements/hadoop-mapr/post-install.d/99-requiretty
+++ b/elements/hadoop-mapr/post-install.d/99-requiretty
@@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
 set -eu
+set -o pipefail
 
 if [ "$DISTRO_NAME" = "centos" -o "$DISTRO_NAME" = "rhel" ]; then
     sed '/^Defaults    requiretty*/ s/^/#/' -i /etc/sudoers
diff --git a/elements/hadoop-mapr/post-install.d/99-update-repository b/elements/hadoop-mapr/post-install.d/99-update-repository
index 3c31d1c0..56cda940 100755
--- a/elements/hadoop-mapr/post-install.d/99-update-repository
+++ b/elements/hadoop-mapr/post-install.d/99-update-repository
@@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
 set -eu
+set -o pipefail
 
 if [ "$DISTRO_NAME" = "ubuntu" ]; then
     apt-get update
diff --git a/elements/hadoop-mapr/root.d/0-mapr-check-version b/elements/hadoop-mapr/root.d/0-mapr-check-version
index e3fd32dd..026b27c9 100755
--- a/elements/hadoop-mapr/root.d/0-mapr-check-version
+++ b/elements/hadoop-mapr/root.d/0-mapr-check-version
@@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
 set -eu
+set -o pipefail
 
 echo "MapR version ${DIB_MAPR_VERSION}"
 
diff --git a/elements/hadoop/post-install.d/40-setup-hadoop b/elements/hadoop/post-install.d/40-setup-hadoop
index fc1d65c1..88224aed 100755
--- a/elements/hadoop/post-install.d/40-setup-hadoop
+++ b/elements/hadoop/post-install.d/40-setup-hadoop
@@ -10,6 +10,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 function download_hadoop_package {
     echo "Hadoop version $DIB_HADOOP_VERSION will be injected into image. Starting the download"
diff --git a/elements/hadoop/root.d/0-check-hadoop b/elements/hadoop/root.d/0-check-hadoop
index 83858279..f34051ca 100755
--- a/elements/hadoop/root.d/0-check-hadoop
+++ b/elements/hadoop/root.d/0-check-hadoop
@@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
-set -e
+set -eu
+set -o pipefail
 
 if [ -z "${JAVA_DOWNLOAD_URL:-}" ]; then
     if [ -z "${JAVA_FILE:-}" ]; then
diff --git a/elements/hive/post-install.d/60-hive b/elements/hive/post-install.d/60-hive
index a2b71f7c..973d828c 100755
--- a/elements/hive/post-install.d/60-hive
+++ b/elements/hive/post-install.d/60-hive
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 install-packages wget tar
 
diff --git a/elements/hive/root.d/0-check-hive b/elements/hive/root.d/0-check-hive
index 00863c35..dd15da25 100755
--- a/elements/hive/root.d/0-check-hive
+++ b/elements/hive/root.d/0-check-hive
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 if [ -z "${HIVE_DOWNLOAD_URL:-}" ]; then
     version_check=$(echo $HIVE_VERSION | sed -e '/[0-9]\.[0-9][0-9]\.[0-9]/d')
diff --git a/elements/java/cleanup.d/00-clean-java-vars b/elements/java/cleanup.d/00-clean-java-vars
index dcdf74da..6ce3426f 100755
--- a/elements/java/cleanup.d/00-clean-java-vars
+++ b/elements/java/cleanup.d/00-clean-java-vars
@@ -4,6 +4,7 @@ if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
 set -eu
+set -o pipefail
 
 unset DIB_JAVA_DISTRO
 unset JAVA_RC
diff --git a/elements/mysql/install.d/10-mysql b/elements/mysql/install.d/10-mysql
index 74e52bc6..4b8416e1 100755
--- a/elements/mysql/install.d/10-mysql
+++ b/elements/mysql/install.d/10-mysql
@@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
-set -e
+set -eu
+set -o pipefail
 
 if [ "$DISTRO_NAME" = "fedora" ]; then
     install-packages community-mysql community-mysql-libs community-mysql-server mysql-connector-java
diff --git a/elements/mysql/install.d/99-disable-mysql-on-boot b/elements/mysql/install.d/99-disable-mysql-on-boot
index 36f6de88..3f819c1a 100755
--- a/elements/mysql/install.d/99-disable-mysql-on-boot
+++ b/elements/mysql/install.d/99-disable-mysql-on-boot
@@ -7,6 +7,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 if [ "$DISTRO_NAME" = "ubuntu" ]; then
     if [ -e "/etc/init/mysql.conf" ]; then
diff --git a/elements/oozie/install.d/50-setup-oozie b/elements/oozie/install.d/50-setup-oozie
index 21e415d7..04df20f6 100755
--- a/elements/oozie/install.d/50-setup-oozie
+++ b/elements/oozie/install.d/50-setup-oozie
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 echo "Oozie setup"
 
diff --git a/elements/oozie/post-install.d/90-oozie-war b/elements/oozie/post-install.d/90-oozie-war
index 8ca5b4fc..034edf1f 100755
--- a/elements/oozie/post-install.d/90-oozie-war
+++ b/elements/oozie/post-install.d/90-oozie-war
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 install-packages wget
 
diff --git a/elements/oozie/root.d/0-check-oozie b/elements/oozie/root.d/0-check-oozie
index 2546f82a..0e7b4914 100755
--- a/elements/oozie/root.d/0-check-oozie
+++ b/elements/oozie/root.d/0-check-oozie
@@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
-set -e
+set -eu
+set -o pipefail
 
 if [[ "$DIB_HADOOP_VERSION" < "2.0.0" ]]; then
     if [ -z "${OOZIE_HADOOP_V1_DOWNLOAD_URL:-}" -a -z "${OOZIE_HADOOP_V1_FILE:-}" ]; then
diff --git a/elements/oracle-java/install.d/33-java b/elements/oracle-java/install.d/33-java
index a936955f..d89514d9 100755
--- a/elements/oracle-java/install.d/33-java
+++ b/elements/oracle-java/install.d/33-java
@@ -3,7 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
-set -e
+set -eu
+set -o pipefail
 
 echo "Begin: installation of Java"
 
diff --git a/elements/redhat-lsb/pre-install.d/02-lsb b/elements/redhat-lsb/pre-install.d/02-lsb
index fda45c8a..0de9ba01 100755
--- a/elements/redhat-lsb/pre-install.d/02-lsb
+++ b/elements/redhat-lsb/pre-install.d/02-lsb
@@ -3,5 +3,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 install-packages redhat-lsb
diff --git a/elements/root-passwd/post-install.d/99-setup b/elements/root-passwd/post-install.d/99-setup
index ec60adc9..5ae2c1ec 100755
--- a/elements/root-passwd/post-install.d/99-setup
+++ b/elements/root-passwd/post-install.d/99-setup
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 if [ -z "$DIB_PASSWORD" ]; then
     echo "Error during setup password for root"
diff --git a/elements/sahara-version/install.d/01-sahara-version b/elements/sahara-version/install.d/01-sahara-version
index 9cea123e..243f7ee7 100755
--- a/elements/sahara-version/install.d/01-sahara-version
+++ b/elements/sahara-version/install.d/01-sahara-version
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 if [ -z "$SAHARA_ELEMENTS_COMMIT_ID" -o -z "$DIB_UTILS_COMMIT_ID" -o -z "$DIB_COMMIT_ID" ]; then
     echo "SAHARA_ELEMENTS_COMMIT_ID, DIB_UTILS_COMMIT_ID and DIB_COMMIT_ID must be specified, exiting"
diff --git a/elements/spark/install.d/60-spark b/elements/spark/install.d/60-spark
index 9d55ccf7..1f9ff8cd 100755
--- a/elements/spark/install.d/60-spark
+++ b/elements/spark/install.d/60-spark
@@ -5,6 +5,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 install-packages wget tar
 
diff --git a/elements/spark/post-install.d/20-spark b/elements/spark/post-install.d/20-spark
index 232a69b7..63547d55 100755
--- a/elements/spark/post-install.d/20-spark
+++ b/elements/spark/post-install.d/20-spark
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 # We have to chown the Spark directories to make it usable for the default user
 # Unfortunately the Ubuntu user does not exists when DIB is creating the image
diff --git a/elements/spark/root.d/0-check-spark b/elements/spark/root.d/0-check-spark
index 0c53b85c..abc4a7d5 100755
--- a/elements/spark/root.d/0-check-spark
+++ b/elements/spark/root.d/0-check-spark
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 if [ -z "${SPARK_DOWNLOAD_URL:-}" -a -z "${DIB_HADOOP_VERSION:-}" ]; then
     echo -e "Neither DIB_HADOOP_VERSION nor SPARK_DOWNLOAD_URL are set. Impossible to install Spark.\nAborting"
diff --git a/elements/ssh/install.d/33-ssh b/elements/ssh/install.d/33-ssh
index a0715ae0..508430cc 100755
--- a/elements/ssh/install.d/33-ssh
+++ b/elements/ssh/install.d/33-ssh
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -u
+set -o pipefail
 echo "Begin: install and configure SSH"
 
 # /etc/ssh/sshd_config is provided by openssh-server
diff --git a/elements/storm/install.d/60-storm b/elements/storm/install.d/60-storm
index 8deea6c4..8e1c5b63 100755
--- a/elements/storm/install.d/60-storm
+++ b/elements/storm/install.d/60-storm
@@ -5,6 +5,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -u
+set -o pipefail
 
 install-packages wget unzip build-essential uuid-dev git libtool autoconf pkg-config tar
 
diff --git a/elements/storm/root.d/0-check-storm b/elements/storm/root.d/0-check-storm
index 48e11bfc..b5f2af12 100755
--- a/elements/storm/root.d/0-check-storm
+++ b/elements/storm/root.d/0-check-storm
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 if [ -z "${STORM_DOWNLOAD_URL:-}" -a -z "${DIB_STORM_VERSION:-}"]; then
     echo -e "Neither DIB_STORM_VERSION nor STORM_DOWNLOAD_URL are set. Impossible to install Storm.\nAborting"
diff --git a/elements/swift_hadoop/post-install.d/81-add-jar b/elements/swift_hadoop/post-install.d/81-add-jar
index 523572c4..fa8a2629 100755
--- a/elements/swift_hadoop/post-install.d/81-add-jar
+++ b/elements/swift_hadoop/post-install.d/81-add-jar
@@ -3,6 +3,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 install-packages wget
 
diff --git a/elements/updater/install.d/00-updater b/elements/updater/install.d/00-updater
index 1eaf2d40..0553f31f 100755
--- a/elements/updater/install.d/00-updater
+++ b/elements/updater/install.d/00-updater
@@ -3,5 +3,7 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 install-packages -u
diff --git a/elements/zookeeper/install.d/40-zookeeper b/elements/zookeeper/install.d/40-zookeeper
index 1d56fa1e..ed127ada 100755
--- a/elements/zookeeper/install.d/40-zookeeper
+++ b/elements/zookeeper/install.d/40-zookeeper
@@ -5,6 +5,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 install-packages wget
 
diff --git a/elements/zookeeper/post-install.d/50-zookeeper b/elements/zookeeper/post-install.d/50-zookeeper
index 088e5879..0f446982 100755
--- a/elements/zookeeper/post-install.d/50-zookeeper
+++ b/elements/zookeeper/post-install.d/50-zookeeper
@@ -7,6 +7,8 @@
 if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then
     set -x
 fi
+set -eu
+set -o pipefail
 
 sed -i -e 's,^exit 0$,[ -f /opt/zookeeper/firstboot.sh ] \&\& sh /opt/zookeeper/firstboot.sh; exit 0,' /etc/rc.local