Bump the version of hacking to 1.1.0, with few fixes

Also switch to pycodestyle from pep8 which requires a bump
of the the version of flake8 too.

Skip the following checks for now:
- E123 Closing bracket does not match indentation of opening bracket's line
- E226 Missing whitespace around arithmetic operator
- E402 Module level import not at top of file
- E731 Do not assign a lambda expression, use a def
- W503 Line break occurred before a binary operator

They should be probably revisited and fixed, if possible,
or skipped individually using # noqa

The following checks reported a limited number of errors and
they were fixed directly in this review:
- E241 Multiple spaces after ','
- E501 Line too long (82 > 79 characters)

Change-Id: I1f185d2efd1adf27a26e3ac93f2e1011c0b63124
This commit is contained in:
Luigi Toscano 2018-11-26 19:03:02 +01:00
parent 3ae4c1d6eb
commit 2e157d900a
3 changed files with 9 additions and 2 deletions

View File

@ -120,7 +120,8 @@ class Oozie(s.Service):
@el.provision_event(instance_reference=1)
@g.remote_command(1)
def _rebuild_oozie_war(self, remote, cluster_context):
cmd = 'cp -f /opt/mapr-repository/ext-2.2.zip %(home)s/libext/ext-2.2.zip &&' \
cmd = 'cp -f /opt/mapr-repository/ext-2.2.zip ' \
'%(home)s/libext/ext-2.2.zip &&' \
' %(home)s/bin/oozie-setup.sh -hadoop %(version)s' \
' /opt/mapr/hadoop/hadoop-%(version)s'
args = {'home': self.home_dir(cluster_context),

View File

@ -2,7 +2,7 @@
# of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later.
hacking!=0.13.0,<0.14,>=0.12.0 # Apache-2.0
hacking>=1.1.0 # Apache-2.0
PyMySQL>=0.7.6 # MIT License
bandit>=1.1.0 # Apache-2.0

View File

@ -128,6 +128,12 @@ exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,tools
# [H204] Use assert(Not)Equal to check for equality
# [H205] Use assert(Greater|Less)(Equal) for comparison
enable-extensions=H904,H106,H203,H204,H205
# [E123] Closing bracket does not match indentation of opening bracket's line
# [E226] Missing whitespace around arithmetic operator
# [E402] Module level import not at top of file
# [E731] Do not assign a lambda expression, use a def
# [W503] Line break occurred before a binary operator
ignore=E123,E226,E402,E731,W503
[hacking]
import_exceptions = sahara.i18n