openstack
/
sahara-plugin-storm
Code Issues Proposed changes

Replace assertFalse/assertTrue(a in b) 

Replace 'assertFalse(a in b)' with 'assertNotIn(a, b)'

Replace 'assertTrue(a in b)' with 'assertIn(a, b)'

[H204] Use assert(Not)Equal to check for equality. Unit test assertions
tend to give better messages for more specific assertions. As a result,
assertEqual(...) is preferred over assertTrue(... == ...), and
assertNotEqual(...) is preferred over assertFalse(... == ...).
Off by default.

see more https://docs.openstack.org/hacking/latest/user/hacking.html

Trivial fix.

Change-Id: Ic21fa755faf218bc1c27dc9c839cf6f99f67d287
This commit is contained in:
sunyandi 2018-01-18 19:39:12 +08:00
parent 9ea7d2a589
commit ed53615347
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sahara/tests/unit/plugins/storm/test_config_helper.py
View File

@ -29,22 +29,22 @@ class TestStormConfigHelper(testcase.TestCase):
zk_hostnames = ["s-zoo"]
configs_092 = s_config.generate_storm_config(
master_hostname, zk_hostnames, STORM_092)
self.assertTrue('nimbus.host' in configs_092.keys())
self.assertFalse('nimbus.seeds' in configs_092.keys())
self.assertIn('nimbus.host', configs_092.keys())
self.assertNotIn('nimbus.seeds', configs_092.keys())
tested_versions.append(STORM_092)
configs_101 = s_config.generate_storm_config(
master_hostname, zk_hostnames, STORM_101)
self.assertFalse('nimbus.host' in configs_101.keys())
self.assertTrue('nimbus.seeds' in configs_101.keys())
self.assertTrue('client.jartransformer.class' in configs_101.keys())
self.assertNotIn('nimbus.host', configs_101.keys())
self.assertIn('nimbus.seeds', configs_101.keys())
self.assertIn('client.jartransformer.class', configs_101.keys())
self.assertEqual(configs_101['client.jartransformer.class'],
'org.apache.storm.hack.StormShadeTransformer')
tested_versions.append(STORM_101)
configs_110 = s_config.generate_storm_config(
master_hostname, zk_hostnames, STORM_110)
self.assertFalse('nimbus.host' in configs_110.keys())
self.assertTrue('nimbus.seeds' in configs_110.keys())
self.assertTrue('client.jartransformer.class' in configs_110.keys())
self.assertNotIn('nimbus.host', configs_110.keys())
self.assertIn('nimbus.seeds', configs_110.keys())
self.assertIn('client.jartransformer.class', configs_110.keys())
self.assertEqual(configs_110['client.jartransformer.class'],
'org.apache.storm.hack.StormShadeTransformer')
tested_versions.append(STORM_110)