openstack
/
sahara-plugin-vanilla
Code Issues Proposed changes

Merge "Enable some off-by-default checks"

This commit is contained in:
Jenkins 2017-08-01 13:53:33 +00:00 committed by Gerrit Code Review
parent eea3b368e0 0ebe4ed7c0
commit adf7bc3d4a
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sahara/tests/unit/plugins/vanilla/hadoop2/test_config_helper.py
View File

@ -130,7 +130,7 @@ class TestConfigHelper(base.SaharaTestCase):
} }
opt_name = 'tt' opt_name = 'tt'
default = c_helper._get_spark_opt_default(opt_name) default = c_helper._get_spark_opt_default(opt_name)
self.assertEqual(default, None) self.assertIsNone(default)
opt_name = 'test_name' opt_name = 'test_name'
default = c_helper._get_spark_opt_default(opt_name) default = c_helper._get_spark_opt_default(opt_name)

2
sahara/tests/unit/plugins/vanilla/v2_7_1/test_versionhandler.py
View File

@ -189,7 +189,7 @@ class VersionHandlerTest(base.SaharaTestCase):
def test_get_edp_engine(self, join, get_instance, get_plugin): def test_get_edp_engine(self, join, get_instance, get_plugin):
job_type = '' job_type = ''
ret = self.vh.get_edp_engine(self.cluster, job_type) ret = self.vh.get_edp_engine(self.cluster, job_type)
self.assertEqual(ret, None) self.assertIsNone(ret)
job_type = 'Java' job_type = 'Java'
ret = self.vh.get_edp_engine(self.cluster, job_type) ret = self.vh.get_edp_engine(self.cluster, job_type)

6
tox.ini
View File

@ -99,8 +99,10 @@ commands = bandit -c bandit.yaml -r sahara -n5 -p sahara_default -x tests
show-source = true show-source = true
builtins = _ builtins = _
exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,tools exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,tools
# [H904] Delay string interpolations at logging calls. # [H904] Delay string interpolations at logging calls
enable-extensions=H904 # [H106] Don’t put vim configuration in source files
# [H203] Use assertIs(Not)None to check for None.
enable-extensions=H904,H106,H203
[hacking] [hacking]
import_exceptions = sahara.i18n import_exceptions = sahara.i18n