openstack
/
sahara
Code Issues Proposed changes

Fix compatibility with oslo.db 12.1.0 

oslo.db 12.1.0 has changed the default value for the 'autocommit'
parameter of 'LegacyEngineFacade' from 'True' to 'False'. This is a
necessary step to ensure compatibility with SQLAlchemy 2.0. However, we
are currently relying on the autocommit behavior and need changes to
explicitly manage sessions. Until that happens, we need to override the
default.

Co-Authored-By: Stephen Finucane <stephenfin@redhat.com>
Change-Id: I5dda36e43caeeb2983cb6a9e0743591fc246d323
This commit is contained in:
Alfredo Moralejo 2022-09-16 11:03:33 +02:00 committed by Dmitriy Rabotyagov
parent ebc6d74bf8
commit 5e7258bcc8
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sahara/db/sqlalchemy/api.py
View File

@ -48,8 +48,12 @@ def _create_facade_lazily():
if _FACADE is None:
with _LOCK:
if _FACADE is None:
# FIXME(amoralej): Remove autocommit=True (and ideally use of
# LegacyEngineFacade) asap since it's not compatible with
# SQLAlchemy 2.0.
_FACADE = db_session.EngineFacade.from_config(CONF,
sqlite_fk=True)
sqlite_fk=True,
autocommit=True)
return _FACADE