openstack
/
sahara
Code Issues Proposed changes

Added #nosec to sahara.utils.hacking package 

The sahara.utils.hacking package is used for testing, as such the
usages of subprocess within it should be marked as nosec according
to the bandit documentation.

Change-Id: If9299b050b9b158a78ab90b63afd94a5d4cbbf2c
Closes-Bug: #1552468
This commit is contained in:
Tin Lam 2016-03-02 23:17:49 -06:00
parent 67816de1f5
commit d0c4351685
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sahara/utils/hacking/commit_message.py
View File

@ -12,7 +12,7 @@
import os
import re
import subprocess
import subprocess # nosec
from hacking import core
@ -23,7 +23,7 @@ class GitCheck(core.GlobalCheck):
def _get_commit_title(self):
# Check if we're inside a git checkout
try:
subp = subprocess.Popen(
subp = subprocess.Popen( # nosec
['git', 'rev-parse', '--show-toplevel'],
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
gitdir = subp.communicate()[0].rstrip()
@ -35,7 +35,7 @@ class GitCheck(core.GlobalCheck):
return None
# Get title of most recent commit
subp = subprocess.Popen(
subp = subprocess.Popen( # nosec
['git', 'log', '--no-merges', '--pretty=%s', '-1'],
stdout=subprocess.PIPE)
title = subp.communicate()[0]