Update patch set 1
Patch Set 1: Code-Review-1 (1 comment) Fantastic, thanks a lot! I'll do a proper review later. For now just wanted to note that I think this should probably go under a new doc/source/testing/ subdirectory, not under doc/source/eris/ since IIUC it's not specific to eris. Also you will need to add it to the index to avoid the current failure: 2019-08-07 15:54:24.386532 | ubuntu-bionic | Warning, treated as error: 2019-08-07 15:54:24.386727 | ubuntu-bionic | /home/zuul/src/opendev.org/openstack/self-healing-sig/doc/source/eris/tools-list.rst:document isn't included in any toctree You can test this locally yourself simply by running tox. Patch-set: 1 Label: Code-Review=-1
This commit is contained in:
parent
74b056c7ec
commit
3490a3858c
27
2cf921fe9e1b81a1bf4e80c5100e7be926679afc
Normal file
27
2cf921fe9e1b81a1bf4e80c5100e7be926679afc
Normal file
@ -0,0 +1,27 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_a107e5c9",
|
||||
"filename": "doc/source/eris/tools-list.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 2,
|
||||
"author": {
|
||||
"id": 2394
|
||||
},
|
||||
"writtenOn": "2019-08-07T16:47:25Z",
|
||||
"side": 1,
|
||||
"message": "functional",
|
||||
"range": {
|
||||
"startLine": 2,
|
||||
"startChar": 32,
|
||||
"endLine": 2,
|
||||
"endChar": 41
|
||||
},
|
||||
"revId": "2cf921fe9e1b81a1bf4e80c5100e7be926679afc",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user