openstack
/
senlin
Code Issues Proposed changes

Remove a TODO item in node object module 

The get_all() method is heavy weight and the result is always paginated.
In recent changes, we have eliminated the calls to get_all() leaving
only the service level node_list() function calling this method. This
TODO is now resolved. We can remove it.

Change-Id: Id6dd73322a4f945fdcca262734196f88b2cf5d1a
This commit is contained in:
tengqm 2017-03-01 22:36:31 -05:00
parent f6ba8ea6c4
commit 33aa4a1296
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
senlin/objects/node.py
View File

@ -124,8 +124,6 @@ class Node(base.SenlinObject, base.VersionedObjectDictCompat):
@classmethod
def get_all(cls, context, **kwargs):
# TODO(anyone): This has to be improved. The DB API called always
# does pagination which is an overkill.
objs = db_api.node_get_all(context, **kwargs)
return [cls._from_db_object(context, cls(), obj) for obj in objs]