openstack/senlin
Code Issues Proposed changes

Fix formatting strings when using multiple variables

Browse Source 
Following OpenStack Style Guidelines:[H703]
http://docs.openstack.org/developer/hacking/#internationalization-i18n-strings

Using multiple variables for formmatting strings
is not clear as using explicit dictionaries and
can hide errors during refactoring.

Change-Id: I9f15dc5b8e491cdb8ef9037fc56d912496bc66ea
This commit is contained in:
Nam Nguyen Hoai
2016-08-30 14:25:46 +07:00
parent bda961ba6a
commit 4c2d27ea40
4 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
senlin/engine/event.py
View File

@@ -126,7 +126,8 @@ def error(context, entity, action, status=None, status_reason=None,
action=action, status=status, status_reason=status_reason,
user=context.user, project=context.project)
event.store(context)
LOG.error(_LE('%(name)s [%(id)s] %(action)s - %(status)s: %(reason)s'),
msg = _LE('%(name)s [%(id)s] %(action)s - %(status)s: %(reason)s')
LOG.error(msg,
{'name': event.oname,
'id': event.oid and event.oid[:8],
'action': action,
@@ -141,7 +142,8 @@ def warning(context, entity, action, status=None, status_reason=None,
action=action, status=status, status_reason=status_reason,
user=context.user, project=context.project)
event.store(context)
LOG.warning(_LW('%(name)s [%(id)s] %(action)s - %(status)s: %(reason)s'),
msg = _LW('%(name)s [%(id)s] %(action)s - %(status)s: %(reason)s')
LOG.warning(msg,
{'name': event.oname,
'id': event.oid and event.oid[:8],
'action': action,