openstack/senlin
Code Issues Proposed changes

Fix misuse of assertTrue

Browse Source 
The first argument of assertTrue should not be True,
otherwise the assertTrue will be useless and always pass.

Change-Id: I20ef33b1406f475c443f4ac41cd449a3d7770829
This commit is contained in:
zhufl 2019-04-02 16:18:05 +08:00
parent 3132c9df49
commit 5366111665
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
senlin/tests/unit/engine/test_cluster_policy.py
View File

@ -42,7 +42,7 @@ class TestClusterPolicy(base.SenlinTestCase):
self.assertEqual(CLUSTER_ID, cp.cluster_id)
self.assertEqual(POLICY_ID, cp.policy_id)
self.assertEqual(12, cp.priority)
self.assertTrue(True, cp.enabled)
self.assertTrue(cp.enabled)
self.assertEqual({}, cp.data)
self.assertIsNone(cp.last_op)
self.assertEqual('', cp.cluster_name)
@ -113,7 +113,7 @@ class TestClusterPolicy(base.SenlinTestCase):
self.assertEqual(cp_id, result.id)
self.assertEqual(cluster.id, result.cluster_id)
self.assertEqual(policy.id, result.policy_id)
self.assertTrue(True, result.enabled)
self.assertTrue(result.enabled)
self.assertEqual(12, result.priority)
self.assertEqual({}, result.data)
self.assertIsNone(result.last_op)