openstack/senlin
Code Issues Proposed changes

Added profile type checking for UPDATE actions

Browse Source 
We only allow UPDATE actions with the same profile type.
This commit is contained in:
tengqm 2015-01-03 12:19:23 +08:00
parent 2048447280
commit 782ada6e20
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
senlin/engine/node.py
View File

@ -172,6 +172,16 @@ class Node(object):
if not self.physical_id:
return False
# Check if profile types match
old_profile = db_api.get_profile(context, self.profile_id)
new_profile = db_api.get_profile(context, new_profile_id)
if old_profile.type != new_profile.type:
events.warning(_LW('Node cannot be updated to a different '
'profile type (%(oldt)s->%(newt)s)'),
{'oldt': old_profile.type,
'newt': new_profile.type})
return False
res = profiles.update_object(self, new_profile_id)
if res:
self.rt['profile'] = profiles.load(self.context, new_profile_id)