openstack/senlin
Code Issues Proposed changes

Merge "Raise Exception when the paramter is invalid"

Browse Source
This commit is contained in:
Jenkins
2016-02-20 03:48:15 +00:00
committed by Gerrit Code Review
parent 4abeb2d8b3 e142999d89
commit 873ee4762e
10 changed files with 180 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
senlin/api/openstack/v1/actions.py
View File

@@ -68,6 +68,10 @@ class ActionController(wsgi.Controller):
consts.PARAM_SORT: 'single',
consts.PARAM_GLOBAL_PROJECT: 'single',
}
for key in req.params.keys():
if (key not in param_whitelist.keys() and key not in
filter_whitelist.keys()):
raise exc.HTTPBadRequest(_('Invalid parameter %s') % key)
params = util.get_allowed_params(req.params, param_whitelist)
filters = util.get_allowed_params(req.params, filter_whitelist)

4
senlin/api/openstack/v1/clusters.py
View File

@@ -139,6 +139,10 @@ class ClusterController(wsgi.Controller):
consts.PARAM_SORT: 'single',
consts.PARAM_GLOBAL_PROJECT: 'single',
}
for key in req.params.keys():
if (key not in param_whitelist.keys() and key not in
filter_whitelist.keys()):
raise exc.HTTPBadRequest(_('Invalid parameter %s') % key)
params = util.get_allowed_params(req.params, param_whitelist)
filters = util.get_allowed_params(req.params, filter_whitelist)

6
senlin/api/openstack/v1/events.py
View File

@@ -13,10 +13,12 @@
"""
Event endpoint for Senlin v1 ReST API.
"""
from webob import exc
from senlin.api.common import util
from senlin.api.common import wsgi
from senlin.common import consts
from senlin.common.i18n import _
from senlin.common import utils
@@ -42,6 +44,10 @@ class EventController(wsgi.Controller):
consts.PARAM_SORT: 'single',
consts.PARAM_GLOBAL_PROJECT: 'single',
}
for key in req.params.keys():
if (key not in param_whitelist.keys() and key not in
filter_whitelist.keys()):
raise exc.HTTPBadRequest(_('Invalid parameter %s') % key)
params = util.get_allowed_params(req.params, param_whitelist)
filters = util.get_allowed_params(req.params, filter_whitelist)

4
senlin/api/openstack/v1/nodes.py
View File

@@ -77,6 +77,10 @@ class NodeController(wsgi.Controller):
consts.PARAM_SORT: 'single',
consts.PARAM_GLOBAL_PROJECT: 'single',
}
for key in req.params.keys():
if (key not in param_whitelist.keys() and key not in
filter_whitelist.keys()):
raise exc.HTTPBadRequest(_('Invalid parameter %s') % key)
params = util.get_allowed_params(req.params, param_whitelist)
filters = util.get_allowed_params(req.params, filter_whitelist)

4
senlin/api/openstack/v1/receivers.py
View File

@@ -79,6 +79,10 @@ class ReceiverController(wsgi.Controller):
consts.PARAM_SORT: 'single',
consts.PARAM_GLOBAL_PROJECT: 'single',
}
for key in req.params.keys():
if (key not in param_whitelist.keys() and key not in
filter_whitelist.keys()):
raise exc.HTTPBadRequest(_('Invalid parameter %s') % key)
params = util.get_allowed_params(req.params, param_whitelist)
filters = util.get_allowed_params(req.params, filter_whitelist)