openstack
/
senlin
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(1 comment)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 35916 \u003c35916@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35916\u003e replied on the change"}
This commit is contained in:
Gerrit User 35916 2024-01-14 06:52:00 +00:00 committed by Gerrit Code Review
parent 7267edb05e
commit a4b4901b73
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
d6c6f923359184eedc38d51151b4fa58c23688a8
View File

@ -33,6 +33,24 @@
"message": "It looks like it would work. Technically find_type only exists in cinder v3 of OpenStack SDK (https://github.com/openstack/openstacksdk/blob/master/openstack/block_storage/v3/_proxy.py#L274). But since cinder v2 has been removed since Xena, this change is fine. The filename should probably be changed to cinder_v3 at some point to avoid confusion.",
"revId": "d6c6f923359184eedc38d51151b4fa58c23688a8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6a2eda10_94a24fe3",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 35916
},
"writtenOn": "2024-01-14T06:52:00Z",
"side": 1,
"message": "Agreed. Do I need to edit anything else before this gets merged?",
"parentUuid": "1eb556bc_00b023c0",
"revId": "d6c6f923359184eedc38d51151b4fa58c23688a8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}