Update patch set 8

Patch Set 8:

(1 comment)

I think there was a misunderstanding.  My previous suggestion was closer to your previous implementation in patch set #4.  But instead of creating the name in octavia_v2.py, you can create the names in lbaas.py and pass the name into the methods like loadbalancer_creater, listener_create, etc in octavia_v2.py.  The lb_create function in lbaas.py should take the cluster name as an argument and then create the LB name by concatenating it with the random string.

Patch-set: 8
Reviewer: Gerrit User 27224 <27224@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 27224 2021-03-31 16:09:42 +00:00 committed by Gerrit Code Review
parent 2a5cc7238b
commit a934561526
1 changed files with 21 additions and 0 deletions

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "c8211929_307243ce",
"filename": "senlin/policies/lb_policy.py",
"patchSetId": 8
},
"lineNbr": 312,
"author": {
"id": 27224
},
"writtenOn": "2021-03-31T16:09:42Z",
"side": 1,
"message": "I don\u0027t think it is a good idea to let users specify the LB name in the policy. All the load balancers will end up with the same name because a policy could be attached to multiple clusters.",
"revId": "8e94b05666f0624e81cef15a9af15b4163a13244",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}