From c8e9bae56af127448d24135f4d5688808ab6bac0 Mon Sep 17 00:00:00 2001 From: yanyanhu Date: Wed, 25 Mar 2015 01:21:34 -0400 Subject: [PATCH] Store user_id in user property of Cluster Now user_id rather then username will be used to fill in the user property of Cluster object. Also remove the unexisted property *user* from RequestContext. Change-Id: I9dd754144272168565b3aefd7e61118d1288dc7f --- senlin/common/context.py | 1 - senlin/engine/service.py | 2 +- senlin/tests/common/utils.py | 2 +- senlin/tests/db/shared.py | 4 ++-- senlin/tests/db/test_cluster_api.py | 2 +- senlin/tests/db/test_webhook_api.py | 2 +- senlin/tests/engine/test_clusters.py | 2 +- 7 files changed, 7 insertions(+), 8 deletions(-) diff --git a/senlin/common/context.py b/senlin/common/context.py index d9cb8a2f4..5f58774a9 100644 --- a/senlin/common/context.py +++ b/senlin/common/context.py @@ -92,7 +92,6 @@ class RequestContext(context.RequestContext): 'auth_url': self.auth_url, 'auth_token': self.auth_token, 'auth_token_info': self.auth_token_info, - 'user': self.user, 'username': self.username, 'user_id': self.user_id, 'password': self.password, diff --git a/senlin/engine/service.py b/senlin/engine/service.py index c869825a7..d01622a32 100644 --- a/senlin/engine/service.py +++ b/senlin/engine/service.py @@ -424,7 +424,7 @@ class EngineService(service.Service): LOG.info(_LI('Creating cluster %s'), name) ctx = context.to_dict() kwargs = { - 'user': ctx.get('username', ''), + 'user': ctx.get('user_id', ''), 'project': ctx.get('tenant_id', ''), 'parent': parent, 'timeout': timeout, diff --git a/senlin/tests/common/utils.py b/senlin/tests/common/utils.py index 508c4545f..358fff1d4 100644 --- a/senlin/tests/common/utils.py +++ b/senlin/tests/common/utils.py @@ -65,7 +65,7 @@ def reset_dummy_db(): def dummy_context(user='test_username', tenant_id='test_tenant_id', - password='password', roles=None, user_id=None, + password='password', roles=None, user_id='test_user_id', trust_id=None, region_name=None): roles = roles or [] return context.RequestContext.from_dict({ diff --git a/senlin/tests/db/shared.py b/senlin/tests/db/shared.py index f764b2aaa..fc216335c 100644 --- a/senlin/tests/db/shared.py +++ b/senlin/tests/db/shared.py @@ -61,7 +61,7 @@ def create_cluster(ctx, profile, **kwargs): values = { 'name': 'db_test_cluster_name', 'profile_id': profile.id, - 'user': ctx.user, + 'user': ctx.user_id, 'project': ctx.tenant_id, 'domain': 'unknown', 'parent': None, @@ -103,7 +103,7 @@ def create_node(ctx, cluster, profile, **kwargs): def create_webhook(ctx, obj_id, obj_type, action, **kwargs): values = { 'name': 'test_webhook_name', - 'user': ctx.user, + 'user': ctx.user_id, 'project': ctx.tenant_id, 'domain': ctx.domain, 'created_time': None, diff --git a/senlin/tests/db/test_cluster_api.py b/senlin/tests/db/test_cluster_api.py index 9c4b766d9..270a033fe 100644 --- a/senlin/tests/db/test_cluster_api.py +++ b/senlin/tests/db/test_cluster_api.py @@ -35,7 +35,7 @@ class DBAPIClusterTest(base.SenlinTestCase): self.assertIsNotNone(cluster.id) self.assertEqual('db_test_cluster_name', cluster.name) self.assertEqual(self.profile.id, cluster.profile_id) - self.assertEqual(self.ctx.username, cluster.user) + self.assertEqual(self.ctx.user_id, cluster.user) self.assertEqual(self.ctx.tenant_id, cluster.project) self.assertEqual('unknown', cluster.domain) self.assertIsNone(cluster.parent) diff --git a/senlin/tests/db/test_webhook_api.py b/senlin/tests/db/test_webhook_api.py index 38a620090..c53fcd6b0 100644 --- a/senlin/tests/db/test_webhook_api.py +++ b/senlin/tests/db/test_webhook_api.py @@ -38,7 +38,7 @@ class DBAPIWebhookTest(base.SenlinTestCase): self.assertIsNotNone(webhook) self.assertEqual(UUID1, webhook.obj_id) self.assertEqual('test_webhook_name', webhook.name) - self.assertEqual(self.ctx.user, webhook.user) + self.assertEqual(self.ctx.user_id, webhook.user) self.assertEqual(self.ctx.domain, webhook.domain) self.assertEqual(self.ctx.tenant_id, webhook.project) self.assertIsNone(webhook.created_time) diff --git a/senlin/tests/engine/test_clusters.py b/senlin/tests/engine/test_clusters.py index 48e079740..0161f05d7 100644 --- a/senlin/tests/engine/test_clusters.py +++ b/senlin/tests/engine/test_clusters.py @@ -66,7 +66,7 @@ class ClusterTest(base.SenlinTestCase): self.assertEqual('c-1', result['name']) self.assertEqual(0, result['size']) self.assertEqual(self.profile['id'], result['profile_id']) - self.assertEqual(self.ctx.user, result['user']) + self.assertEqual(self.ctx.user_id, result['user']) self.assertEqual('cluster_test_tenant', result['project']) self.assertIsNone(result['parent']) self.assertIsNone(result['timeout'])