419 lines
16 KiB
Python
419 lines
16 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from unittest import mock
|
|
|
|
from senlin.common import consts
|
|
from senlin.common import exception as exc
|
|
from senlin.common import scaleutils as su
|
|
from senlin.engine import cluster as cluster_mod
|
|
from senlin.objects import cluster as co
|
|
from senlin.objects import node as no
|
|
from senlin.policies import base as policy_base
|
|
from senlin.policies import zone_placement as zp
|
|
from senlin.tests.unit.common import base
|
|
from senlin.tests.unit.common import utils
|
|
|
|
|
|
class TestZonePlacementPolicy(base.SenlinTestCase):
|
|
|
|
def setUp(self):
|
|
super(TestZonePlacementPolicy, self).setUp()
|
|
self.context = utils.dummy_context()
|
|
self.spec = {
|
|
'type': 'senlin.policy.zone_placement',
|
|
'version': '1.0',
|
|
'properties': {
|
|
'zones': [
|
|
{'name': 'AZ1', 'weight': 100},
|
|
{'name': 'AZ2', 'weight': 80},
|
|
{'name': 'AZ3', 'weight': 60},
|
|
{'name': 'AZ4', 'weight': 40}
|
|
]
|
|
}
|
|
}
|
|
|
|
def test_policy_init(self):
|
|
policy = zp.ZonePlacementPolicy('test-policy', self.spec)
|
|
|
|
self.assertIsNone(policy.id)
|
|
self.assertEqual('test-policy', policy.name)
|
|
self.assertEqual('senlin.policy.zone_placement-1.0', policy.type)
|
|
expected = {'AZ1': 100, 'AZ2': 80, 'AZ3': 60, 'AZ4': 40}
|
|
self.assertEqual(expected, policy.zones)
|
|
|
|
@mock.patch.object(policy_base.Policy, 'validate')
|
|
def test_validate_okay(self, mock_base_validate):
|
|
policy = zp.ZonePlacementPolicy('test-policy', self.spec)
|
|
nc = mock.Mock()
|
|
nc.validate_azs.return_value = ['AZ1', 'AZ2', 'AZ3', 'AZ4']
|
|
policy._novaclient = nc
|
|
ctx = mock.Mock(user='U1', project='P1')
|
|
|
|
res = policy.validate(ctx, True)
|
|
|
|
self.assertTrue(res)
|
|
mock_base_validate.assert_called_once_with(ctx, True)
|
|
nc.validate_azs.assert_called_once_with(['AZ1', 'AZ2', 'AZ3', 'AZ4'])
|
|
|
|
@mock.patch.object(policy_base.Policy, 'validate')
|
|
def test_validate_no_validate_props(self, mock_base_validate):
|
|
policy = zp.ZonePlacementPolicy('test-policy', self.spec)
|
|
ctx = mock.Mock(user='U1', project='P1')
|
|
|
|
res = policy.validate(ctx, False)
|
|
|
|
self.assertTrue(res)
|
|
mock_base_validate.assert_called_once_with(ctx, False)
|
|
|
|
@mock.patch.object(policy_base.Policy, 'validate')
|
|
def test_validate_az_not_found(self, mock_base_validate):
|
|
policy = zp.ZonePlacementPolicy('test-policy', self.spec)
|
|
nc = mock.Mock()
|
|
nc.validate_azs.return_value = ['AZ1', 'AZ4']
|
|
policy._novaclient = nc
|
|
ctx = mock.Mock(user='U1', project='P1')
|
|
|
|
ex = self.assertRaises(exc.InvalidSpec,
|
|
policy.validate,
|
|
ctx, True)
|
|
|
|
mock_base_validate.assert_called_once_with(ctx, True)
|
|
nc.validate_azs.assert_called_once_with(['AZ1', 'AZ2', 'AZ3', 'AZ4'])
|
|
self.assertEqual("The specified name '['AZ2', 'AZ3']' "
|
|
"could not be found.", str(ex))
|
|
|
|
def test_create_plan_default(self):
|
|
self.spec['properties']['zones'] = [
|
|
{'name': 'AZ1'}, {'name': 'AZ2'}, {'name': 'AZ3'}, {'name': 'AZ4'}
|
|
]
|
|
policy = zp.ZonePlacementPolicy('test-policy', self.spec)
|
|
zones = policy.zones
|
|
|
|
current = {'AZ1': 2, 'AZ2': 2, 'AZ3': 2, 'AZ4': 1}
|
|
plan = policy._create_plan(current, zones, 5, True)
|
|
answer = {'AZ1': 1, 'AZ2': 1, 'AZ3': 1, 'AZ4': 2}
|
|
self.assertEqual(answer, plan)
|
|
|
|
def test_create_plan(self):
|
|
policy = zp.ZonePlacementPolicy('test-policy', self.spec)
|
|
zones = policy.zones
|
|
|
|
current = {'AZ1': 2, 'AZ2': 2, 'AZ3': 2, 'AZ4': 1}
|
|
plan = policy._create_plan(current, zones, 7, True)
|
|
answer = {'AZ1': 3, 'AZ2': 2, 'AZ3': 1, 'AZ4': 1}
|
|
self.assertEqual(answer, plan)
|
|
|
|
current = {'AZ1': 2, 'AZ2': 4, 'AZ3': 2, 'AZ4': 2}
|
|
plan = policy._create_plan(current, zones, 6, True)
|
|
answer = {'AZ1': 4, 'AZ2': 1, 'AZ3': 1}
|
|
self.assertEqual(answer, plan)
|
|
|
|
current = {'AZ1': 4, 'AZ2': 5, 'AZ3': 1, 'AZ4': 1}
|
|
plan = policy._create_plan(current, zones, 3, False)
|
|
answer = {'AZ2': 3}
|
|
self.assertEqual(answer, plan)
|
|
|
|
current = {'AZ1': 6, 'AZ2': 2, 'AZ3': 4, 'AZ4': 6}
|
|
plan = policy._create_plan(current, zones, 4, False)
|
|
answer = {'AZ4': 4}
|
|
self.assertEqual(answer, plan)
|
|
|
|
def test_get_count_node_create_with_zone(self):
|
|
x_profile = mock.Mock(AVAILABILITY_ZONE='availability_zone',
|
|
properties={'availability_zone': 'zone1'})
|
|
x_node = mock.Mock(rt={'profile': x_profile})
|
|
action = mock.Mock(action=consts.NODE_CREATE, entity=x_node)
|
|
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
self.assertEqual(0, res)
|
|
|
|
def test_get_count_node_create_without_zone(self):
|
|
x_profile = mock.Mock(AVAILABILITY_ZONE='availability_zone',
|
|
properties={'availability_zone': None})
|
|
x_node = mock.Mock(rt={'profile': x_profile})
|
|
action = mock.Mock(action=consts.NODE_CREATE, entity=x_node)
|
|
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
self.assertEqual(1, res)
|
|
|
|
def test_get_count_resize_deletion(self):
|
|
action = mock.Mock(action=consts.CLUSTER_RESIZE,
|
|
data={'deletion': {'count': 3}})
|
|
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
self.assertEqual(-3, res)
|
|
|
|
def test_get_count_resize_creation(self):
|
|
action = mock.Mock(action=consts.CLUSTER_RESIZE,
|
|
data={'creation': {'count': 3}})
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
self.assertEqual(3, res)
|
|
|
|
@mock.patch.object(no.Node, 'count_by_cluster')
|
|
@mock.patch.object(su, 'parse_resize_params')
|
|
@mock.patch.object(co.Cluster, 'get')
|
|
def test_get_count_resize_parse_error(self, mock_cluster, mock_parse,
|
|
mock_count):
|
|
x_cluster = mock.Mock()
|
|
mock_cluster.return_value = x_cluster
|
|
mock_count.return_value = 3
|
|
mock_parse.return_value = (policy_base.CHECK_ERROR, 'Something wrong.')
|
|
action = mock.Mock(action=consts.CLUSTER_RESIZE, data={})
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
|
|
self.assertEqual(0, res)
|
|
self.assertEqual(policy_base.CHECK_ERROR, action.data['status'])
|
|
self.assertEqual('Something wrong.', action.data['reason'])
|
|
mock_cluster.assert_called_once_with(action.context, 'FOO')
|
|
mock_count.assert_called_once_with(action.context, 'FOO')
|
|
mock_parse.assert_called_once_with(action, x_cluster, 3)
|
|
|
|
@mock.patch.object(no.Node, 'count_by_cluster')
|
|
@mock.patch.object(su, 'parse_resize_params')
|
|
@mock.patch.object(co.Cluster, 'get')
|
|
def test_get_count_resize_parse_creation(self, mock_cluster, mock_parse,
|
|
mock_count):
|
|
def fake_parse(action, cluster, current):
|
|
action.data = {'creation': {'count': 3}}
|
|
return policy_base.CHECK_OK, ''
|
|
|
|
x_cluster = mock.Mock()
|
|
mock_cluster.return_value = x_cluster
|
|
mock_parse.side_effect = fake_parse
|
|
mock_count.return_value = 3
|
|
action = mock.Mock(action=consts.CLUSTER_RESIZE, data={})
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
|
|
self.assertEqual(3, res)
|
|
mock_cluster.assert_called_once_with(action.context, 'FOO')
|
|
mock_count.assert_called_once_with(action.context, 'FOO')
|
|
mock_parse.assert_called_once_with(action, x_cluster, 3)
|
|
|
|
@mock.patch.object(no.Node, 'count_by_cluster')
|
|
@mock.patch.object(su, 'parse_resize_params')
|
|
@mock.patch.object(co.Cluster, 'get')
|
|
def test_get_count_resize_parse_deletion(self, mock_cluster, mock_parse,
|
|
mock_count):
|
|
def fake_parse(action, cluster, current):
|
|
action.data = {'deletion': {'count': 3}}
|
|
return policy_base.CHECK_OK, ''
|
|
|
|
x_cluster = mock.Mock()
|
|
mock_cluster.return_value = x_cluster
|
|
mock_count.return_value = 3
|
|
mock_parse.side_effect = fake_parse
|
|
action = mock.Mock(action=consts.CLUSTER_RESIZE, data={})
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
|
|
self.assertEqual(-3, res)
|
|
mock_cluster.assert_called_once_with(action.context, 'FOO')
|
|
mock_count.assert_called_once_with(action.context, 'FOO')
|
|
mock_parse.assert_called_once_with(action, x_cluster, 3)
|
|
|
|
def test_get_count_scale_in_with_data(self):
|
|
action = mock.Mock(action=consts.CLUSTER_SCALE_IN,
|
|
data={'deletion': {'count': 3}})
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
self.assertEqual(-3, res)
|
|
|
|
def test_get_count_scale_in_with_no_data(self):
|
|
action = mock.Mock(action=consts.CLUSTER_SCALE_IN,
|
|
data={'deletion': {'num': 3}})
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
self.assertEqual(-1, res)
|
|
|
|
def test_get_count_scale_in_with_inputs(self):
|
|
action = mock.Mock(action=consts.CLUSTER_SCALE_IN, data={},
|
|
inputs={'count': 3})
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
self.assertEqual(-3, res)
|
|
|
|
def test_get_count_scale_in_with_incorrect_inputs(self):
|
|
action = mock.Mock(action=consts.CLUSTER_SCALE_IN, data={},
|
|
inputs={'num': 3})
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
self.assertEqual(-1, res)
|
|
|
|
def test_get_count_scale_out_with_data(self):
|
|
action = mock.Mock(action=consts.CLUSTER_SCALE_OUT,
|
|
data={'creation': {'count': 3}})
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
self.assertEqual(3, res)
|
|
|
|
def test_get_count_scale_out_with_no_data(self):
|
|
action = mock.Mock(action=consts.CLUSTER_SCALE_OUT,
|
|
data={'creation': {'num': 3}})
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
self.assertEqual(1, res)
|
|
|
|
def test_get_count_scale_out_with_inputs(self):
|
|
action = mock.Mock(action=consts.CLUSTER_SCALE_OUT, data={},
|
|
inputs={'count': 3})
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
self.assertEqual(3, res)
|
|
|
|
def test_get_count_scale_out_with_incorrect_inputs(self):
|
|
action = mock.Mock(action=consts.CLUSTER_SCALE_OUT, data={},
|
|
inputs={'num': 3})
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
|
|
res = policy._get_count('FOO', action)
|
|
self.assertEqual(1, res)
|
|
|
|
@mock.patch.object(cluster_mod.Cluster, 'load')
|
|
def test_pre_op_expand_using_input(self, mock_load):
|
|
policy = zp.ZonePlacementPolicy('test-policy', self.spec)
|
|
zones = policy.zones
|
|
|
|
nc = mock.Mock()
|
|
nc.validate_azs.return_value = zones.keys()
|
|
policy._novaclient = nc
|
|
|
|
action = mock.Mock()
|
|
action.action = 'CLUSTER_SCALE_OUT'
|
|
action.context = self.context
|
|
action.data = {}
|
|
action.inputs = {'count': 7}
|
|
|
|
cluster = mock.Mock(user='user1', project='project1')
|
|
current_dist = {'AZ1': 2, 'AZ2': 3, 'AZ3': 2, 'AZ4': 1}
|
|
cluster.get_zone_distribution.return_value = current_dist
|
|
mock_load.return_value = cluster
|
|
|
|
policy.pre_op('FAKE_CLUSTER', action)
|
|
|
|
self.assertEqual(7, action.data['creation']['count'])
|
|
dist = action.data['creation']['zones']
|
|
self.assertEqual(4, dist['AZ1'])
|
|
self.assertEqual(2, dist['AZ2'])
|
|
self.assertEqual(1, dist['AZ3'])
|
|
|
|
mock_load.assert_called_once_with(action.context, 'FAKE_CLUSTER')
|
|
nc.validate_azs.assert_called_once_with(zones.keys())
|
|
cluster.get_zone_distribution.assert_called_once_with(
|
|
action.context, zones.keys())
|
|
|
|
@mock.patch.object(cluster_mod.Cluster, 'load')
|
|
def test_pre_op_shrink_using_data(self, mock_load):
|
|
policy = zp.ZonePlacementPolicy('test-policy', self.spec)
|
|
zones = policy.zones
|
|
|
|
nc = mock.Mock()
|
|
nc.validate_azs.return_value = zones.keys()
|
|
policy._novaclient = nc
|
|
|
|
action = mock.Mock(action=consts.CLUSTER_SCALE_IN,
|
|
context=self.context, inputs={},
|
|
data={'deletion': {'count': 2}})
|
|
|
|
cluster = mock.Mock(user='user1', project='project1')
|
|
current_dist = {'AZ1': 2, 'AZ2': 2, 'AZ3': 2, 'AZ4': 1}
|
|
cluster.get_zone_distribution.return_value = current_dist
|
|
mock_load.return_value = cluster
|
|
|
|
policy.pre_op('FAKE_CLUSTER', action)
|
|
|
|
self.assertEqual(2, action.data['deletion']['count'])
|
|
dist = action.data['deletion']['zones']
|
|
self.assertEqual(1, dist['AZ3'])
|
|
self.assertEqual(1, dist['AZ4'])
|
|
|
|
mock_load.assert_called_once_with(action.context, 'FAKE_CLUSTER')
|
|
nc.validate_azs.assert_called_once_with(zones.keys())
|
|
cluster.get_zone_distribution.assert_called_once_with(
|
|
action.context, zones.keys())
|
|
|
|
@mock.patch.object(cluster_mod.Cluster, 'load')
|
|
def test_pre_op_no_zones(self, mock_load):
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
nc = mock.Mock()
|
|
nc.validate_azs.return_value = []
|
|
policy._novaclient = nc
|
|
|
|
action = mock.Mock(action=consts.CLUSTER_SCALE_OUT,
|
|
context=self.context,
|
|
data={'creation': {'count': 3}})
|
|
|
|
cluster = mock.Mock()
|
|
mock_load.return_value = cluster
|
|
|
|
res = policy.pre_op('FAKE_CLUSTER', action)
|
|
|
|
self.assertIsNone(res)
|
|
self.assertEqual('ERROR', action.data['status'])
|
|
self.assertEqual('No availability zone found available.',
|
|
action.data['reason'])
|
|
|
|
@mock.patch.object(cluster_mod.Cluster, 'load')
|
|
def test_pre_op_no_feasible_plan(self, mock_load):
|
|
policy = zp.ZonePlacementPolicy('p1', self.spec)
|
|
zones = policy.zones
|
|
|
|
nc = mock.Mock()
|
|
nc.validate_azs.return_value = zones.keys()
|
|
policy._novaclient = nc
|
|
|
|
self.patchobject(policy, '_create_plan', return_value=None)
|
|
|
|
action = mock.Mock(action=consts.CLUSTER_SCALE_OUT,
|
|
context=self.context, inputs={},
|
|
data={'creation': {'count': 3}})
|
|
|
|
cluster = mock.Mock()
|
|
current_dist = {'R1': 0, 'R2': 0, 'R3': 0, 'R4': 0}
|
|
cluster.get_zone_distribution.return_value = current_dist
|
|
mock_load.return_value = cluster
|
|
|
|
res = policy.pre_op('FAKE_CLUSTER', action)
|
|
|
|
self.assertIsNone(res)
|
|
|
|
self.assertEqual('ERROR', action.data['status'])
|
|
self.assertEqual('There is no feasible plan to handle all nodes.',
|
|
action.data['reason'])
|
|
|
|
mock_load.assert_called_once_with(action.context, 'FAKE_CLUSTER')
|
|
nc.validate_azs.assert_called_once_with(zones.keys())
|
|
cluster.get_zone_distribution.assert_called_once_with(
|
|
action.context, zones.keys())
|
|
policy._create_plan.assert_called_once_with(
|
|
current_dist, zones, 3, True)
|