1067 lines
43 KiB
Python
1067 lines
43 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
import six
|
|
from webob import exc
|
|
|
|
from oslo_serialization import jsonutils
|
|
|
|
from senlin.api.common import util
|
|
from senlin.api.middleware import fault
|
|
from senlin.api.openstack.v1 import nodes
|
|
from senlin.common import exception as senlin_exc
|
|
from senlin.common import policy
|
|
from senlin.rpc import client as rpc_client
|
|
from senlin.tests.unit.api import shared
|
|
from senlin.tests.unit.common import base
|
|
|
|
|
|
@mock.patch.object(policy, 'enforce')
|
|
class NodeControllerTest(shared.ControllerTest, base.SenlinTestCase):
|
|
|
|
def setUp(self):
|
|
super(NodeControllerTest, self).setUp()
|
|
|
|
class DummyConfig(object):
|
|
bind_port = 8778
|
|
|
|
cfgopts = DummyConfig()
|
|
self.controller = nodes.NodeController(options=cfgopts)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_index(self, mock_call, mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'index', True)
|
|
req = self._get('/nodes')
|
|
|
|
engine_resp = [
|
|
{
|
|
u'id': u'aaaa-bbbb-cccc',
|
|
u'name': u'node-1',
|
|
u'cluster_id': None,
|
|
u'physical_id': None,
|
|
u'profile_id': u'pppp-rrrr-oooo-ffff',
|
|
u'profile_name': u'my_stack_profile',
|
|
u'index': 1,
|
|
u'role': None,
|
|
u'init_time': u'2015-01-23T13:06:00Z',
|
|
u'created_time': u'2015-01-23T13:07:22Z',
|
|
u'updated_time': None,
|
|
u'status': u'ACTIVE',
|
|
u'status_reason': u'Node successfully created',
|
|
u'data': {},
|
|
u'metadata': {},
|
|
}
|
|
]
|
|
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
mock_call.return_value = engine_resp
|
|
|
|
result = self.controller.index(req)
|
|
|
|
self.assertEqual(engine_resp, result['nodes'])
|
|
mock_parse.assert_called_once_with(
|
|
'NodeListRequest', req, {'project_safe': True})
|
|
mock_call.assert_called_once_with(
|
|
req.context, 'node_list', obj)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_index_whitelists_params(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'index', True)
|
|
marker_uuid = '69814221-5013-4cb6-a943-6bfe9837547d'
|
|
params = {
|
|
'name': 'node01',
|
|
'status': 'ACTIVE',
|
|
'cluster_id': 'id or name of a cluster',
|
|
'limit': '10',
|
|
'marker': marker_uuid,
|
|
'sort': 'name:asc',
|
|
'global_project': 'True',
|
|
}
|
|
req = self._get('/nodes', params=params)
|
|
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
mock_call.return_value = []
|
|
|
|
result = self.controller.index(req)
|
|
|
|
self.assertEqual([], result['nodes'])
|
|
mock_parse.assert_called_once_with(
|
|
'NodeListRequest', req,
|
|
{
|
|
'status': ['ACTIVE'],
|
|
'sort': 'name:asc',
|
|
'name': ['node01'],
|
|
'limit': '10',
|
|
'marker': marker_uuid,
|
|
'cluster_id': 'id or name of a cluster',
|
|
'project_safe': False
|
|
})
|
|
mock_call.assert_called_once_with(
|
|
req.context, 'node_list', obj)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_index_whitelists_invalid_params(self, mock_call,
|
|
mock_parse,
|
|
mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'index', True)
|
|
params = {
|
|
'balrog': 'you shall not pass!'
|
|
}
|
|
req = self._get('/nodes', params=params)
|
|
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.index, req)
|
|
|
|
self.assertEqual("Invalid parameter balrog",
|
|
str(ex))
|
|
self.assertFalse(mock_call.called)
|
|
self.assertFalse(mock_parse.called)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_index_global_project_true(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'index', True)
|
|
params = {'global_project': 'True'}
|
|
req = self._get('/nodes', params=params)
|
|
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
error = senlin_exc.Forbidden()
|
|
mock_call.side_effect = shared.to_remote_error(error)
|
|
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.index,
|
|
req)
|
|
|
|
self.assertEqual(403, resp.json['code'])
|
|
self.assertEqual('Forbidden', resp.json['error']['type'])
|
|
mock_parse.assert_called_once_with(
|
|
"NodeListRequest", mock.ANY, {'project_safe': False})
|
|
mock_call.assert_called_once_with(req.context, 'node_list', obj)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_index_global_project_false(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'index', True)
|
|
params = {'global_project': 'False'}
|
|
req = self._get('/nodes', params=params)
|
|
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
mock_call.return_value = []
|
|
|
|
result = self.controller.index(req)
|
|
|
|
self.assertEqual([], result['nodes'])
|
|
mock_parse.assert_called_once_with(
|
|
'NodeListRequest', req, {'project_safe': True})
|
|
mock_call.assert_called_once_with(
|
|
req.context, 'node_list', obj)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_index_global_project_not_bool(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'index', True)
|
|
params = {'global_project': 'No'}
|
|
req = self._get('/nodes', params=params)
|
|
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.index, req)
|
|
|
|
self.assertEqual("Invalid value 'No' specified for 'global_project'",
|
|
six.text_type(ex))
|
|
self.assertFalse(mock_parse.called)
|
|
self.assertFalse(mock_call.called)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_index_limit_not_int(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'index', True)
|
|
params = {'limit': 'not-int'}
|
|
req = self._get('/nodes', params=params)
|
|
|
|
mock_parse.side_effect = exc.HTTPBadRequest("bad limit")
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.index, req)
|
|
|
|
self.assertEqual("bad limit", six.text_type(ex))
|
|
mock_parse.assert_called_once_with(
|
|
'NodeListRequest', req,
|
|
{'limit': 'not-int', 'project_safe': True})
|
|
self.assertFalse(mock_call.called)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_index_cluster_not_found(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'index', True)
|
|
cluster_id = 'non-existent'
|
|
req = self._get('/nodes', {'cluster_id': cluster_id})
|
|
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
msg = "Cannot find the given cluster: non-existent"
|
|
error = senlin_exc.BadRequest(msg=msg)
|
|
mock_call.side_effect = shared.to_remote_error(error)
|
|
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.index, req)
|
|
self.assertEqual(400, resp.json['code'])
|
|
self.assertEqual('BadRequest', resp.json['error']['type'])
|
|
mock_parse.assert_called_once_with(
|
|
'NodeListRequest', mock.ANY,
|
|
{
|
|
'cluster_id': 'non-existent',
|
|
'project_safe': True
|
|
})
|
|
mock_call.assert_called_once_with(
|
|
req.context, 'node_list', obj)
|
|
|
|
def test_node_index_denied_policy(self, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'index', False)
|
|
req = self._get('/nodes')
|
|
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.index, req)
|
|
self.assertEqual(403, resp.status_int)
|
|
self.assertIn('403 Forbidden', six.text_type(resp))
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_create_success(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'create', True)
|
|
body = {
|
|
'node': {
|
|
'name': 'test_node',
|
|
'profile_id': 'xxxx-yyyy',
|
|
'cluster_id': None,
|
|
'role': None,
|
|
'metadata': {},
|
|
}
|
|
}
|
|
|
|
engine_response = {
|
|
'id': 'test_node_id',
|
|
'name': 'test_node',
|
|
'profile_id': 'xxxx-yyyy',
|
|
'cluster_id': None,
|
|
'role': None,
|
|
'metadata': {},
|
|
'action': 'fake_action'
|
|
}
|
|
|
|
req = self._post('/nodes', jsonutils.dumps(body))
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
mock_call.return_value = engine_response
|
|
|
|
resp = self.controller.create(req, body=body)
|
|
expected = {
|
|
'node': engine_response,
|
|
'location': '/actions/fake_action'
|
|
}
|
|
self.assertEqual(expected, resp)
|
|
mock_parse.assert_called_once_with(
|
|
'NodeCreateRequest', req, body, 'node')
|
|
mock_call.assert_called_once_with(
|
|
req.context, 'node_create', mock.ANY)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_create_with_bad_body(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'create', True)
|
|
body = {'foo': 'bar'}
|
|
req = self._post('/nodes', jsonutils.dumps(body))
|
|
mock_parse.side_effect = exc.HTTPBadRequest("bad param")
|
|
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.create,
|
|
req, body=body)
|
|
|
|
self.assertEqual("bad param", six.text_type(ex))
|
|
mock_parse.assert_called_once_with(
|
|
'NodeCreateRequest', req, body, 'node')
|
|
self.assertFalse(mock_call.called)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_create_with_missing_profile_id(self, mock_call,
|
|
mock_parse,
|
|
mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'create', True)
|
|
body = {
|
|
'node': {
|
|
'name': 'test_node'
|
|
}
|
|
}
|
|
|
|
req = self._post('/nodes', jsonutils.dumps(body))
|
|
|
|
mock_parse.side_effect = exc.HTTPBadRequest("miss profile")
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.create,
|
|
req, body=body)
|
|
self.assertEqual("miss profile", six.text_type(ex))
|
|
mock_parse.assert_called_once_with(
|
|
'NodeCreateRequest', req, body, 'node')
|
|
self.assertFalse(mock_call.called)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_create_with_missing_name(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'create', True)
|
|
body = {
|
|
'node': {
|
|
'profile_id': 'xxxx-yyyy'
|
|
}
|
|
}
|
|
|
|
req = self._post('/nodes', jsonutils.dumps(body))
|
|
|
|
mock_parse.side_effect = exc.HTTPBadRequest("miss name")
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.create,
|
|
req, body=body)
|
|
self.assertEqual("miss name", six.text_type(ex))
|
|
mock_parse.assert_called_once_with(
|
|
'NodeCreateRequest', req, body, 'node')
|
|
self.assertFalse(mock_call.called)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_create_with_bad_profile(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'create', True)
|
|
body = {
|
|
'node': {
|
|
'name': 'test_node',
|
|
'profile_id': 'bad-profile',
|
|
'cluster_id': None,
|
|
'role': None,
|
|
'metadata': {},
|
|
}
|
|
}
|
|
req = self._post('/nodes', jsonutils.dumps(body))
|
|
|
|
error = senlin_exc.ResourceNotFound(type='profile', id='bad-profile')
|
|
mock_call.side_effect = shared.to_remote_error(error)
|
|
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.create,
|
|
req, body=body)
|
|
self.assertEqual(404, resp.json['code'])
|
|
self.assertEqual('ResourceNotFound', resp.json['error']['type'])
|
|
mock_parse.assert_called_once_with(
|
|
'NodeCreateRequest', mock.ANY, body, 'node')
|
|
mock_call.assert_called_once_with(
|
|
req.context, 'node_create', mock.ANY)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_create_with_bad_cluster(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'create', True)
|
|
body = {
|
|
'node': {
|
|
'name': 'test_node',
|
|
'profile_id': 'xxxx-yyyy-zzzz',
|
|
'cluster_id': 'non-existent-cluster',
|
|
'role': None,
|
|
'metadata': {},
|
|
}
|
|
}
|
|
req = self._post('/nodes', jsonutils.dumps(body))
|
|
|
|
error = senlin_exc.ResourceNotFound(type='cluster',
|
|
id='non-existent-cluster')
|
|
mock_call.side_effect = shared.to_remote_error(error)
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.create,
|
|
req, body=body)
|
|
|
|
self.assertEqual(404, resp.json['code'])
|
|
self.assertEqual('ResourceNotFound', resp.json['error']['type'])
|
|
mock_parse.assert_called_once_with(
|
|
'NodeCreateRequest', mock.ANY, body, 'node')
|
|
mock_call.assert_called_once_with(
|
|
req.context, 'node_create', mock.ANY)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_adopt(self, mock_call, mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'adopt', True)
|
|
body = {
|
|
'identity': 'PHYSICAL',
|
|
'type': 'RES-TYPE',
|
|
'name': 'test_node',
|
|
'cluster': 'CLUSTER',
|
|
'role': 'ROLE',
|
|
'metadata': {'MK': 'MV'},
|
|
'overrides': {'NKEY': 'NVAL'},
|
|
'snapshot': True,
|
|
}
|
|
|
|
engine_response = {
|
|
'id': 'test_node_id',
|
|
'name': 'test_node',
|
|
'profile_id': 'xxxx-yyyy',
|
|
'cluster_id': 'test_cluster_id',
|
|
'role': 'ROLE',
|
|
'metadata': {'MK': 'MV'},
|
|
}
|
|
req = self._post('/nodes/adopt', jsonutils.dumps(body),
|
|
version='1.7')
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
mock_call.return_value = engine_response
|
|
|
|
resp = self.controller.adopt(req, body=body)
|
|
|
|
self.assertEqual({'node': engine_response}, resp)
|
|
mock_parse.assert_called_once_with('NodeAdoptRequest', req, body)
|
|
mock_call.assert_called_once_with(req.context, 'node_adopt', mock.ANY)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_adopt_preview(self, mock_call, mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'adopt_preview', True)
|
|
body = {
|
|
'identity': 'PHYSICAL',
|
|
'type': 'PROF-TYPE',
|
|
'overrides': {'NKEY': 'NVAL'},
|
|
'snapshot': True,
|
|
}
|
|
|
|
engine_response = {
|
|
'type': 'PROF-TYPE',
|
|
'properties': {
|
|
'foo': 'bar'
|
|
}
|
|
}
|
|
req = self._post('/nodes/adopt/preview', jsonutils.dumps(body),
|
|
version='1.7')
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
mock_call.return_value = engine_response
|
|
|
|
resp = self.controller.adopt_preview(req, body=body)
|
|
|
|
self.assertEqual({'node_profile': engine_response}, resp)
|
|
mock_parse.assert_called_once_with('NodeAdoptPreviewRequest',
|
|
req, body)
|
|
mock_call.assert_called_once_with(req.context, 'node_adopt_preview',
|
|
mock.ANY)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_get_success(self, mock_call, mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'get', True)
|
|
node_id = 'aaaa-bbbb-cccc'
|
|
req = self._get('/nodes/%(node_id)s' % {'node_id': node_id})
|
|
|
|
engine_resp = {
|
|
u'id': 'aaaa-bbbb-cccc',
|
|
u'name': 'node-1',
|
|
u'cluster_id': None,
|
|
u'physical_id': None,
|
|
u'profile_id': 'pppp-rrrr-oooo-ffff',
|
|
u'profile_name': u'my_stack_profile',
|
|
u'index': 1,
|
|
u'role': None,
|
|
u'init_time': u'2015-01-23T13:06:00Z',
|
|
u'created_time': u'2015-01-23T13:07:22Z',
|
|
u'updated_time': None,
|
|
u'status': u'ACTIVE',
|
|
u'status_reason': u'Node successfully created',
|
|
u'data': {},
|
|
u'metadata': {},
|
|
u'details': {}
|
|
}
|
|
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
mock_call.return_value = engine_resp
|
|
|
|
response = self.controller.get(req, node_id=node_id)
|
|
|
|
self.assertEqual(engine_resp, response['node'])
|
|
mock_parse.assert_called_once_with(
|
|
'NodeGetRequest', req, {'identity': node_id})
|
|
mock_call.assert_called_once_with(req.context, 'node_get', obj)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_get_show_details_not_bool(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'get', True)
|
|
node_id = 'aaaa-bbbb-cccc'
|
|
params = {'show_details': 'Okay'}
|
|
req = self._get('/nodes/%(node_id)s' % {'node_id': node_id},
|
|
params=params)
|
|
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.get,
|
|
req, node_id=node_id)
|
|
|
|
self.assertEqual("Invalid value 'Okay' specified for 'show_details'",
|
|
six.text_type(ex))
|
|
self.assertFalse(mock_parse.called)
|
|
self.assertFalse(mock_call.called)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_get_not_found(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'get', True)
|
|
node_id = 'non-existent-node'
|
|
req = self._get('/nodes/%(node_id)s' % {'node_id': node_id})
|
|
|
|
error = senlin_exc.ResourceNotFound(type='node', id=node_id)
|
|
mock_call.side_effect = shared.to_remote_error(error)
|
|
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.get,
|
|
req, node_id=node_id)
|
|
|
|
self.assertEqual(404, resp.json['code'])
|
|
self.assertEqual('ResourceNotFound', resp.json['error']['type'])
|
|
mock_parse.assert_called_once_with(
|
|
'NodeGetRequest', mock.ANY, {'identity': node_id})
|
|
mock_call.assert_called_once_with(
|
|
req.context, 'node_get', mock.ANY)
|
|
|
|
def test_node_get_denied_policy(self, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'get', False)
|
|
node_id = 'non-existent-node'
|
|
req = self._get('/nodes/%(node_id)s' % {'node_id': node_id})
|
|
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.get,
|
|
req, node_id=node_id)
|
|
|
|
self.assertEqual(403, resp.status_int)
|
|
self.assertIn('403 Forbidden', six.text_type(resp))
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_update_success(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'update', True)
|
|
nid = 'aaaa-bbbb-cccc'
|
|
body = {
|
|
'node': {
|
|
'name': 'test_node',
|
|
'profile_id': 'xxxx-yyyy',
|
|
'role': None,
|
|
'metadata': {},
|
|
}
|
|
}
|
|
aid = 'xxxx-yyyy-zzzz'
|
|
|
|
engine_response = body['node'].copy()
|
|
engine_response['action'] = aid
|
|
|
|
req = self._patch('/nodes/%(node_id)s' % {'node_id': nid},
|
|
jsonutils.dumps(body))
|
|
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
mock_call.return_value = engine_response
|
|
|
|
res = self.controller.update(req, node_id=nid, body=body)
|
|
|
|
mock_parse.assert_called_once_with(
|
|
'NodeUpdateRequest', req,
|
|
{
|
|
'name': 'test_node',
|
|
'profile_id': 'xxxx-yyyy',
|
|
'role': None,
|
|
'metadata': {},
|
|
'identity': nid
|
|
})
|
|
mock_call.assert_called_once_with(req.context, 'node_update', obj)
|
|
result = {
|
|
'node': engine_response,
|
|
'location': '/actions/%s' % aid,
|
|
}
|
|
self.assertEqual(result, res)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_update_malformed_request(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'update', True)
|
|
nid = 'aaaa-bbbb-cccc'
|
|
body = {'name': 'new name'}
|
|
|
|
req = self._patch('/nodes/%(node_id)s' % {'node_id': nid},
|
|
jsonutils.dumps(body))
|
|
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.update, req,
|
|
node_id=nid, body=body)
|
|
self.assertEqual("Malformed request data, missing 'node' key "
|
|
"in request body.", six.text_type(ex))
|
|
self.assertFalse(mock_parse.called)
|
|
self.assertFalse(mock_call.called)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_update_not_found(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'update', True)
|
|
nid = 'non-exist-node'
|
|
body = {
|
|
'node': {
|
|
'name': 'test_node',
|
|
'profile_id': 'xxxx-yyyy',
|
|
'role': None,
|
|
'metadata': {},
|
|
}
|
|
}
|
|
|
|
req = self._patch('/nodes/%(node_id)s' % {'node_id': nid},
|
|
jsonutils.dumps(body))
|
|
|
|
error = senlin_exc.ResourceNotFound(type='node', id=nid)
|
|
mock_call.side_effect = shared.to_remote_error(error)
|
|
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.update,
|
|
req, node_id=nid, body=body)
|
|
|
|
mock_call.assert_called_with(req.context, 'node_update', mock.ANY)
|
|
|
|
self.assertEqual(404, resp.json['code'])
|
|
self.assertEqual('ResourceNotFound', resp.json['error']['type'])
|
|
msg = "The node 'non-exist-node' could not be found."
|
|
self.assertEqual(msg, resp.json['error']['message'])
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_update_invalid_profile(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'update', True)
|
|
nid = 'aaaa-bbbb-cccc'
|
|
body = {
|
|
'node': {
|
|
'name': 'test_node',
|
|
'profile_id': 'profile-not-exist',
|
|
'role': None,
|
|
'metadata': {},
|
|
}
|
|
}
|
|
|
|
req = self._patch('/nodes/%(node_id)s' % {'node_id': nid},
|
|
jsonutils.dumps(body))
|
|
|
|
error = senlin_exc.ResourceNotFound(type='profile', id=nid)
|
|
mock_call.side_effect = shared.to_remote_error(error)
|
|
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.update,
|
|
req, node_id=nid, body=body)
|
|
mock_parse.assert_called_once_with(
|
|
'NodeUpdateRequest', mock.ANY, mock.ANY)
|
|
mock_call.assert_called_once_with(
|
|
req.context, 'node_update', mock.ANY)
|
|
self.assertEqual(404, resp.json['code'])
|
|
self.assertEqual('ResourceNotFound', resp.json['error']['type'])
|
|
msg = "The profile 'aaaa-bbbb-cccc' could not be found."
|
|
self.assertEqual(msg, resp.json['error']['message'])
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_update_cluster_id_specified(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'update', True)
|
|
nid = 'aaaa-bbbb-cccc'
|
|
body = {'node': {'cluster_id': 'xxxx-yyyy-zzzz'}}
|
|
|
|
req = self._patch('/nodes/%(node_id)s' % {'node_id': nid},
|
|
jsonutils.dumps(body))
|
|
|
|
mock_parse.side_effect = exc.HTTPBadRequest("miss cluster")
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.update,
|
|
req, node_id=nid, body=body)
|
|
|
|
self.assertEqual("miss cluster", six.text_type(ex))
|
|
mock_parse.assert_called_once_with(
|
|
'NodeUpdateRequest', req, mock.ANY)
|
|
self.assertFalse(mock_call.called)
|
|
|
|
def test_node_update_denied_policy(self, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'update', False)
|
|
node_id = 'test-node-1'
|
|
body = {
|
|
'node': {
|
|
'name': 'test_node',
|
|
'profile_id': 'xxxx-yyyy',
|
|
'role': None,
|
|
'metadata': {},
|
|
}
|
|
}
|
|
req = self._patch('/nodes/%(node_id)s' % {'node_id': node_id},
|
|
jsonutils.dumps(body))
|
|
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.update,
|
|
req, node_id=node_id, body=body)
|
|
|
|
self.assertEqual(403, resp.status_int)
|
|
self.assertIn('403 Forbidden', six.text_type(resp))
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_delete_success(self, mock_call, mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'delete', True)
|
|
nid = 'aaaa-bbbb-cccc'
|
|
req = self._delete('/nodes/%(node_id)s' % {'node_id': nid},
|
|
params={'force': False})
|
|
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
mock_call.return_value = {'action': 'FAKE_ID'}
|
|
|
|
res = self.controller.delete(req, node_id=nid)
|
|
|
|
result = {'location': '/actions/FAKE_ID'}
|
|
self.assertEqual(res, result)
|
|
mock_parse.assert_called_once_with(
|
|
'NodeDeleteRequest', req,
|
|
{'identity': 'aaaa-bbbb-cccc', 'force': False})
|
|
mock_call.assert_called_once_with(req.context, 'node_delete', obj)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_delete_err_malformed_node_id(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'delete', True)
|
|
nid = {'k1': 'v1'}
|
|
req = self._delete('/nodes/%(node_id)s' % {'node_id': nid},
|
|
params={'force': False})
|
|
|
|
mock_parse.side_effect = exc.HTTPBadRequest("bad node")
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.delete, req,
|
|
node_id=nid)
|
|
self.assertEqual("bad node", six.text_type(ex))
|
|
self.assertFalse(mock_call.called)
|
|
mock_parse.assert_called_once_with(
|
|
'NodeDeleteRequest', req, {'identity': nid, 'force': False})
|
|
|
|
def test_node_delete_err_denied_policy(self, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'delete', False)
|
|
nid = 'aaaa-bbbb-cccc'
|
|
req = self._delete('/nodes/%(node_id)s' % {'node_id': nid},
|
|
params={'force': False})
|
|
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.delete,
|
|
req, node_id=nid)
|
|
|
|
self.assertEqual(403, resp.status_int)
|
|
self.assertIn('403 Forbidden', six.text_type(resp))
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_delete_not_found(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'delete', True)
|
|
nid = 'aaaa-bbbb-cccc'
|
|
req = self._delete('/nodes/%(node_id)s' % {'node_id': nid},
|
|
params={'force': False})
|
|
|
|
error = senlin_exc.ResourceNotFound(type='node', id=nid)
|
|
mock_call.side_effect = shared.to_remote_error(error)
|
|
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.delete,
|
|
req, node_id=nid)
|
|
|
|
self.assertEqual(404, resp.json['code'])
|
|
self.assertEqual('ResourceNotFound', resp.json['error']['type'])
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_delete_force(self, mock_call, mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'delete', True)
|
|
nid = 'aaaa-bbbb-cccc'
|
|
req = self._delete('/nodes/%(node_id)s' % {'node_id': nid},
|
|
params={'force': 'true'})
|
|
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
mock_call.return_value = {'action': 'FAKE_ID'}
|
|
params = {'node_id': nid, 'body': {'force': True}}
|
|
res = self.controller.delete(req, **params)
|
|
|
|
result = {'location': '/actions/FAKE_ID'}
|
|
self.assertEqual(res, result)
|
|
mock_parse.assert_called_once_with(
|
|
'NodeDeleteRequest', req,
|
|
{'identity': 'aaaa-bbbb-cccc', 'force': True})
|
|
mock_call.assert_called_once_with(req.context, 'node_delete', obj)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_action_check_success(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'action', True)
|
|
node_id = 'test-node-1'
|
|
body = {'check': {}}
|
|
req = self._post('/nodes/%(node_id)s/actions' % {'node_id': node_id},
|
|
jsonutils.dumps(body))
|
|
|
|
engine_response = {'action': 'action-id'}
|
|
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
mock_call.return_value = engine_response
|
|
|
|
response = self.controller.action(req, node_id=node_id, body=body)
|
|
|
|
location = {'location': '/actions/action-id'}
|
|
engine_response.update(location)
|
|
self.assertEqual(engine_response, response)
|
|
mock_parse.assert_called_once_with(
|
|
'NodeCheckRequest', req,
|
|
{'params': {}, 'identity': 'test-node-1'})
|
|
mock_call.assert_called_once_with(req.context, 'node_check', obj)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_action_check_node_not_found(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'action', True)
|
|
node_id = 'unknown-node'
|
|
body = {'check': {}}
|
|
req = self._post('/nodes/%(node_id)s/actions' % {'node_id': node_id},
|
|
jsonutils.dumps(body))
|
|
|
|
error = senlin_exc.ResourceNotFound(type='node', id=node_id)
|
|
mock_call.side_effect = shared.to_remote_error(error)
|
|
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.action,
|
|
req, node_id=node_id, body=body)
|
|
|
|
self.assertEqual(404, resp.json['code'])
|
|
self.assertEqual('ResourceNotFound', resp.json['error']['type'])
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_action_recover_success(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'action', True)
|
|
node_id = 'xxxx-yyyy'
|
|
body = {'recover': {}}
|
|
req = self._post('/nodes/%(node_id)s/actions' % {'node_id': node_id},
|
|
jsonutils.dumps(body))
|
|
|
|
engine_response = {'action': 'action-id'}
|
|
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
mock_call.return_value = engine_response
|
|
|
|
response = self.controller.action(req, node_id=node_id, body=body)
|
|
|
|
location = {'location': '/actions/action-id'}
|
|
engine_response.update(location)
|
|
self.assertEqual(engine_response, response)
|
|
mock_parse.assert_called_once_with(
|
|
'NodeRecoverRequest', req,
|
|
{'params': {}, 'identity': 'xxxx-yyyy'})
|
|
mock_call.assert_called_once_with(req.context, 'node_recover', obj)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_action_recover_node_not_found(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'action', True)
|
|
node_id = 'xxxx-yyyy'
|
|
body = {'recover': {}}
|
|
req = self._post('/nodes/%(node_id)s/actions' % {'node_id': node_id},
|
|
jsonutils.dumps(body))
|
|
|
|
error = senlin_exc.ResourceNotFound(type='node', id=node_id)
|
|
mock_call.side_effect = shared.to_remote_error(error)
|
|
|
|
resp = shared.request_with_middleware(fault.FaultWrapper,
|
|
self.controller.action,
|
|
req, node_id=node_id, body=body)
|
|
|
|
self.assertEqual(404, resp.json['code'])
|
|
self.assertEqual('ResourceNotFound', resp.json['error']['type'])
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_action_invalid_params(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'action', True)
|
|
node_id = 'unknown-node'
|
|
body = {'check': 'foo'}
|
|
req = self._post('/nodes/%(node_id)s/actions' % {'node_id': node_id},
|
|
jsonutils.dumps(body))
|
|
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.action,
|
|
req, node_id=node_id, body=body)
|
|
self.assertEqual("The params provided is not a map.",
|
|
six.text_type(ex))
|
|
self.assertFalse(mock_parse.called)
|
|
self.assertFalse(mock_call.called)
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_action_missing_action(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'action', True)
|
|
node_id = 'xxxx-yyyy'
|
|
body = {}
|
|
req = self._post('/nodes/%(node_id)s/actions' % {'node_id': node_id},
|
|
jsonutils.dumps(body))
|
|
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.action, req,
|
|
node_id=node_id, body=body)
|
|
|
|
self.assertFalse(mock_parse.called)
|
|
self.assertFalse(mock_call.called)
|
|
self.assertEqual(400, ex.code)
|
|
self.assertIn('No action specified.', six.text_type(ex))
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_action_multiple_action(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'action', True)
|
|
node_id = 'xxxx-yyyy'
|
|
body = {'eat': {}, 'sleep': {}}
|
|
req = self._post('/nodes/%(node_id)s/actions' % {'node_id': node_id},
|
|
jsonutils.dumps(body))
|
|
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.action,
|
|
req, node_id=node_id, body=body)
|
|
|
|
self.assertFalse(mock_parse.called)
|
|
self.assertFalse(mock_call.called)
|
|
self.assertEqual(400, ex.code)
|
|
self.assertIn('Multiple actions specified.', six.text_type(ex))
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_action_unknown_action(self, mock_call,
|
|
mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'action', True)
|
|
node_id = 'xxxx-yyyy'
|
|
body = {'eat': None}
|
|
req = self._post('/nodes/%(node_id)s/action' % {'node_id': node_id},
|
|
jsonutils.dumps(body))
|
|
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.action,
|
|
req, node_id=node_id, body=body)
|
|
|
|
self.assertFalse(mock_parse.called)
|
|
self.assertFalse(mock_call.called)
|
|
self.assertEqual(400, ex.code)
|
|
self.assertIn("Unrecognized action 'eat' specified",
|
|
six.text_type(ex))
|
|
|
|
@mock.patch.object(util, 'parse_request')
|
|
@mock.patch.object(rpc_client.EngineClient, 'call')
|
|
def test_node_operation(self, mock_call, mock_parse, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'operation', True)
|
|
node_id = 'xxxx-yyyy'
|
|
body = {'dance': {'style': 'rumba'}}
|
|
req = self._post('/nodes/%(node_id)s/ops' % {'node_id': node_id},
|
|
jsonutils.dumps(body), version='1.4')
|
|
|
|
engine_response = {'action': 'action-id'}
|
|
obj = mock.Mock()
|
|
mock_parse.return_value = obj
|
|
mock_call.return_value = engine_response
|
|
|
|
response = self.controller.operation(req, node_id=node_id,
|
|
body=body)
|
|
|
|
expected_response = {'location': '/actions/action-id',
|
|
'action': 'action-id'}
|
|
|
|
self.assertEqual(response, expected_response)
|
|
mock_parse.assert_called_once_with(
|
|
'NodeOperationRequest', req,
|
|
{'identity': 'xxxx-yyyy',
|
|
'operation': 'dance',
|
|
'params': {'style': 'rumba'}
|
|
})
|
|
mock_call.assert_called_once_with(req.context, 'node_op', obj)
|
|
|
|
def test_node_operation_version_mismatch(self, mock_enforce):
|
|
node_id = 'xxxx-yyyy'
|
|
body = {}
|
|
req = self._post('/nodes/%(node_id)s/ops' % {'node_id': node_id},
|
|
jsonutils.dumps(body), version='1.3')
|
|
|
|
ex = self.assertRaises(senlin_exc.MethodVersionNotFound,
|
|
self.controller.operation,
|
|
req, node_id=node_id, body=body)
|
|
|
|
self.assertEqual("API version '1.3' is not supported on this "
|
|
"method.", six.text_type(ex))
|
|
|
|
def test_node_operation_missing_operation(self, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'operation', True)
|
|
node_id = 'xxxx-yyyy'
|
|
body = {}
|
|
req = self._post('/nodes/%(node_id)s/ops' % {'node_id': node_id},
|
|
jsonutils.dumps(body), version='1.4')
|
|
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.operation, req,
|
|
node_id=node_id, body=body)
|
|
|
|
self.assertEqual(400, ex.code)
|
|
self.assertIn('No operation specified.', six.text_type(ex))
|
|
|
|
def test_node_operation_multiple_operation(self, mock_enforce):
|
|
self._mock_enforce_setup(mock_enforce, 'operation', True)
|
|
node_id = 'xxxx-yyyy'
|
|
body = {'eat': {}, 'sleep': {}}
|
|
req = self._post('/nodes/%(node_id)s/ops' % {'node_id': node_id},
|
|
jsonutils.dumps(body), version='1.4')
|
|
|
|
ex = self.assertRaises(exc.HTTPBadRequest,
|
|
self.controller.operation,
|
|
req, node_id=node_id, body=body)
|
|
|
|
self.assertEqual(400, ex.code)
|
|
self.assertIn('Multiple operations specified.', six.text_type(ex))
|