From 56ebe515af20a1e8078e04299c277692553a4561 Mon Sep 17 00:00:00 2001 From: Gerrit User 3099 <3099@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 12 Jan 2015 21:32:50 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: Code-Review-1 (1 comment) One suggested improvement to catch the initial failure if there are cascading failures. Patch-set: 1 Label: Code-Review=-1 --- 75c385ac4eef885e831a70435d8d3f3ace3d80f5 | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 75c385ac4eef885e831a70435d8d3f3ace3d80f5 diff --git a/75c385ac4eef885e831a70435d8d3f3ace3d80f5 b/75c385ac4eef885e831a70435d8d3f3ace3d80f5 new file mode 100644 index 000000000..43c53c70c --- /dev/null +++ b/75c385ac4eef885e831a70435d8d3f3ace3d80f5 @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "key": { + "uuid": "3a961159_5d86aebb", + "filename": "shade/__init__.py", + "patchSetId": 1 + }, + "lineNbr": 708, + "author": { + "id": 3099 + }, + "writtenOn": "2015-01-12T21:32:50Z", + "side": 1, + "message": "I\u0027d make this the first line of the exception handling, in case the other ironic_client calls in this section should happen to fail. I won\u0027t mention how those are not being caught.... oops, too late.", + "revId": "75c385ac4eef885e831a70435d8d3f3ace3d80f5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file