openstack/skyline-apiserver
Code Issues Proposed changes

refactor: Prefer separate LABEL instructions

Browse Source 
LABELs can go to separate directives, which does not induce a penalty
on the image since docker 1.10.

See also https://dockerlabs.collabnix.com/beginners/dockerfile/Label_instruction.html

Change-Id: Iac33480bc3f4069ab904279ad61b5c58746318c0
This commit is contained in:
Florian Haftmann 2023-02-28 15:09:52 +01:00
parent bec6c457e5
commit 4546837e14
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
container/Dockerfile
View File

@ -1,3 +1,4 @@
FROM ubuntu:20.04
ARG GIT_BRANCH
@ -6,10 +7,10 @@ ARG GIT_CONSOLE_COMMIT
ARG RELEASE_VERSION
ARG SKYLINE_CONSOLE_PACKAGE_URL
LABEL skyline.build_branch=${GIT_BRANCH}\
skyline.build_commit=${GIT_COMMIT} \
skyline.build_console_commit=${GIT_CONSOLE_COMMIT} \
skyline.release_version=${RELEASE_VERSION}
LABEL skyline.build_branch=${GIT_BRANCH}
LABEL skyline.build_commit=${GIT_COMMIT}
LABEL skyline.build_console_commit=${GIT_CONSOLE_COMMIT}
LABEL skyline.release_version=${RELEASE_VERSION}
ENV LANG C.UTF-8
ENV LC_ALL C.UTF-8