From 6a4be31ccd043d421ea5926d9db5f8b5807abc1b Mon Sep 17 00:00:00 2001 From: Ghanshyam Mann Date: Tue, 22 Dec 2020 09:08:06 -0600 Subject: [PATCH] Move stackviz-nodejs10-run-test-browser to Firefox stackviz-nodejs10-run-test-browser job started failing on chrome browser - https://bugs.launchpad.net/stackviz/+bug/1908606 Horizon and its plugins also moved the nodejs browser jobs to firefox now, let's move stackviz jobs too to make this job green. Closes-Bug: #1908606 Change-Id: I4a63a54ee5fce983c3254805b39549d145159be9 --- .zuul.yaml | 5 ++--- package.json | 2 +- test/karma.conf.js | 2 +- test/protractor.conf.js | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.zuul.yaml b/.zuul.yaml index 8430985..aa1e8bd 100644 --- a/.zuul.yaml +++ b/.zuul.yaml @@ -34,8 +34,7 @@ check: jobs: - stackviz-nodejs10-run-lint - # TODO(gmann): skip until bug#1908606 - #- stackviz-nodejs10-run-test-browser + - stackviz-nodejs10-run-test-browser - tempest-full-py3: irrelevant-files: &irrelevant-files - ^.*\.rst$ @@ -54,7 +53,7 @@ gate: jobs: - stackviz-nodejs10-run-lint - #- stackviz-nodejs10-run-test-browser + - stackviz-nodejs10-run-test-browser post: jobs: diff --git a/package.json b/package.json index d8ccf4c..0ca4bc2 100644 --- a/package.json +++ b/package.json @@ -54,7 +54,7 @@ "jasmine-fixture": "2.0.0", "karma": "~0.13.22", "karma-browserify": "5.0.3", - "karma-chrome-launcher": "0.2.3", + "karma-firefox-launcher": "2.1.0", "karma-coverage": "0.5.5", "karma-jasmine": "0.3.8", "karma-subunit-reporter": "0.0.4", diff --git a/test/karma.conf.js b/test/karma.conf.js index 8f4970d..008e435 100644 --- a/test/karma.conf.js +++ b/test/karma.conf.js @@ -12,7 +12,7 @@ module.exports = function(config) { preprocessors: { 'app/js/**/*.js': ['browserify', 'coverage'] }, - browsers: ['Chrome'], + browsers: ['Firefox'], reporters: ['progress', 'subunit'], autoWatch: true, diff --git a/test/protractor.conf.js b/test/protractor.conf.js index abda3b4..6cf83c7 100644 --- a/test/protractor.conf.js +++ b/test/protractor.conf.js @@ -11,7 +11,7 @@ exports.config = { directConnect: true, capabilities: { - browserName: 'chrome', + browserName: 'firefox', version: '', platform: 'ANY' },