openstack/stackviz
Code Issues Proposed changes

Remove top fixed navbar

Browse Source 
This removes the top fixed navbar in favor of breadcrumb navigation.
The top navbar no longer makes sense with generic artifact types, and
never rendered correctly on small displays (particularly mobile
devices). Instead, each page now displays a small breadcrumb menu.

Change-Id: I18a8bbae24b237e503563cabf854413a54f4be72
This commit is contained in:
Tim Buckley 2016-05-13 17:12:55 -06:00
parent 28caae17d6
commit fbc599f85d
7 changed files with 31 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/index.html
View File

@ -11,16 +11,6 @@
</head>
<body class="ng-cloak" ng-controller="MainController">
<header class="navbar navbar-default navbar-fixed-top navbar-inner">
<div class="container">
<div class="navbar-header">
<a class="navbar-brand" ui-sref="home">StackViz</a>
</div>
<nav ng-include="'menu.html'"></nav>
</div>
</header>
<div role="main" ui-view></div>
<script src="js/main.js"></script>

1
app/styles/_sb-admin-2.scss
View File

@ -6,7 +6,6 @@
body {
background-color: #f8f8f8;
padding-top: 50px;
}
#wrapper {

9
app/views/console.html
View File

@ -3,6 +3,15 @@
<h1 class="page-header">
Console: {{ console.artifactName }}
</h1>
<ol class="breadcrumb">
<li><a ui-sref="home">Home</a></li>
<li>
<a ui-sref="home({artifactName: console.artifactName})">
{{ console.artifactName }}
</a>
</li>
<li class="active">Console</li>
</ol>
</div>
</header>

4
app/views/home.html
View File

@ -2,6 +2,10 @@
<header class="bs-header">
<div class="container">
<h1 class="page-header">Datasets</h1>
<ol class="breadcrumb">
<li><a ui-sref="home">Home</a></li>
<li class="active">{{ home.focus }}</li>
</ol>
</div>
</header>

17
app/views/menu.html
View File

@ -1,17 +0,0 @@
<ul class="nav navbar-top-links navbar-right">
<li>
<a ui-sref="home"><fa name="pie-chart" fw></fa> Overview</a>
</li>
<li uib-dropdown>
<a href uib-dropdown-toggle>
<fa name="bar-chart-o" fw></fa> Tempest <fa name="caret-down"></fa>
</a>
<ul uib-dropdown-menu>
<li>
<a ui-sref="timeline({datasetId: 0})">
<fa name="calendar" fw></fa> Timeline
</a>
</li>
</ul>
</li>
</ul>

9
app/views/test-details.html
View File

@ -1,6 +1,15 @@
<header class="bs-header">
<div class="container">
<h1 class="page-header">Test Details</h1>
<ol class="breadcrumb">
<li><a ui-sref="home">Home</a></li>
<li>
<a ui-sref="home({artifactName: testDetails.artifactName})">
{{ testDetails.artifactName }}
</a>
</li>
<li class="active">Test Details: {{ testDetails.item.name | split:'.' | pickRight:1 }}</li>
</ol>
</div>
</header>

9
app/views/timeline.html
View File

@ -3,6 +3,15 @@
<h1 class="page-header">
Timeline: {{ timeline.artifactName }}
</h1>
<ol class="breadcrumb">
<li><a ui-sref="home">Home</a></li>
<li>
<a ui-sref="home({artifactName: timeline.artifactName})">
{{ timeline.artifactName }}
</a>
</li>
<li class="active">Timeline</li>
</ol>
</div>
</header>