Merge "Remove Extension.extras"

changes/96/875196/1 5.0.0
Zuul 2 months ago committed by Gerrit Code Review
commit c4acc5639f

@ -0,0 +1,7 @@
- |
The ``stevedore.extension.Extension`` object no longer exposes an
``extras`` attribute. Entry point extras are a deprecated concept that
aren't useful in the context of stevedore thus the value in exposing this
is minimal to none.

@ -58,29 +58,6 @@ class Extension(object):
match = self.entry_point.pattern.match(self.entry_point.value)
def extras(self):
"""The 'extras' settings for the plugin."""
# NOTE: The underlying package returned re.Match objects until this was
# fixed in importlib-metadata 4.11.3. This was fixed in Python 3.10 and
# backported to Python 3.9.11. For older versions without this fix,
# translate the re.Match objects to the matched strings, which seem
# more useful.
extras = []
for extra in self.entry_point.extras:
if isinstance(extra, str):
# We were previously returning the whole string including
# backets. We need to continue doing so to preserve API
# compatibility.
# Python 3.6 returns _sre.SRE_Match objects. Later
# versions of python return re.Match objects. Both types
# have a 'string' attribute containing the text that
# matched the pattern.
extras.append(getattr(extra, 'string', extra))
return extras
def attr(self):
"""The attribute of the module to be loaded."""

@ -268,10 +268,6 @@ class TestExtensionProperties(utils.TestCase):
self.assertEqual('', self.ext1.module_name)
self.assertEqual('module', self.ext2.module_name)
def test_extras(self):
self.assertEqual(['[extra]'], self.ext1.extras)
self.assertEqual([], self.ext2.extras)
def test_attr(self):
self.assertEqual('', self.ext1.attr)
self.assertEqual('attribute', self.ext2.attr)