Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 2472 \u003c2472@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_2472\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 15334 \u003c15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_2472\u003e replied on the change"}
This commit is contained in:
Gerrit User 2472 2022-10-04 13:35:43 +00:00 committed by Gerrit Code Review
parent 2bbf4d8357
commit cfe797c05e
1 changed files with 18 additions and 0 deletions

View File

@ -195,6 +195,24 @@
"parentUuid": "a99c6dee_6c6d62c7",
"revId": "8eb97446db69bc34fee40b5a06ac0a9156e204f4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b9025750_18581847",
"filename": "stevedore/extension.py",
"patchSetId": 1
},
"lineNbr": 75,
"author": {
"id": 2472
},
"writtenOn": "2022-10-04T13:35:43Z",
"side": 1,
"message": "\u003e \u003e Are there any tests for this behavior to demonstrate what might break?\n\u003e \n\u003e You\u0027ll note I had to change a test in this change. \n\nI missed that the first time through.\n\n\u003e \u003e The packaging docs imply this feature is deprecated. Maybe we remove the extras property implementation entirely? Would that break OpenStack?\n\u003e \u003e \n\u003e \u003e https://packaging.python.org/en/latest/specifications/entry-points/#data-model\n\u003e \n\u003e Good idea. There are no OpenStack users so we don\u0027t have an issue there. Such a change would not be backportable to stable/zed though. This is an issue there since we support Python 3.9 in Zed, and 3.9.11 includes a backported fix to importlib.metadata that introduces this behavior change. Perhaps I should submit this in its previous incarnation (retaining the brackets) and then do a follow-up to remove the feature entirely, followed by a major version bump?\n\nI think I like that approach. It\u0027s a cleaner break, and since the feature is deprecated we\u0027re likely to have to do it in the future anyway.",
"parentUuid": "1127fd4d_28a23b61",
"revId": "8eb97446db69bc34fee40b5a06ac0a9156e204f4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}