39 lines
1.6 KiB
Plaintext
39 lines
1.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fc883b6b_22b69b3e",
|
|
"filename": "stevedore/extension.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 75,
|
|
"author": {
|
|
"id": 15334
|
|
},
|
|
"writtenOn": "2022-09-09T15:57:43Z",
|
|
"side": 1,
|
|
"message": "I don\u0027t know if I should be doing this. As things stand, these brackets aren\u0027t currently present on Python 3.10 or 3.9.11, only 3.9.10 or lower. We\u0027re changing behavior here and forcing ourselves to carry this forward forever. However, if we don\u0027t add these then we\u0027ll see different results for Python 3.7 and 3.8 unless we change behavior there also.\n\nI\u0027d be tempted to *not* add this and change the behavior for all Python versions (with a release note and potentially major version bump) but I\u0027d like others opinions.",
|
|
"revId": "8eb97446db69bc34fee40b5a06ac0a9156e204f4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "21aa3d83_759d4bca",
|
|
"filename": "stevedore/extension.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 75,
|
|
"author": {
|
|
"id": 28522
|
|
},
|
|
"writtenOn": "2022-09-09T16:05:12Z",
|
|
"side": 1,
|
|
"message": "You propose to change the behavior for all the python versions by abandoning the current solution, or you means that this patch will change the behavior for all Python versions?",
|
|
"parentUuid": "fc883b6b_22b69b3e",
|
|
"revId": "8eb97446db69bc34fee40b5a06ac0a9156e204f4",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |