stevedore/cb128a8abed1e05b3ff06d849da...

61 lines
1.9 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "d32f9ba6_c7bc24a2",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 28522
},
"writtenOn": "2021-10-14T09:50:49Z",
"side": 1,
"message": "Ah sorry I missed that this was a backport... then, please forgot my previous comment.",
"revId": "cb128a8abed1e05b3ff06d849dad1dcb499e75cb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "74f12dd2_2c8e1853",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 28522
},
"writtenOn": "2022-06-22T09:26:01Z",
"side": 1,
"message": "Cherry-picked by a core team member, one single core approval is enough",
"revId": "cb128a8abed1e05b3ff06d849dad1dcb499e75cb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b92e070e_ebd8078c",
"filename": "stevedore/_cache.py",
"patchSetId": 1
},
"lineNbr": 119,
"author": {
"id": 28522
},
"writtenOn": "2021-10-14T09:49:51Z",
"side": 1,
"message": "Hello,\n\nFor a better readibility please can you surround the tuple items with parenthesis?\n\n```\nitem \u003d (ep.name, ep.value, ep.group)\n```\n\nIt would be more readable if we explicitly handle a tuple. With that the comment could be removed.\n\nElse I tested it with various version of python and everything worked.",
"range": {
"startLine": 119,
"startChar": 19,
"endLine": 119,
"endChar": 46
},
"revId": "cb128a8abed1e05b3ff06d849dad1dcb499e75cb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}