From 12c3291507c4c4cbb16318bfdd516c7c9bef6dcb Mon Sep 17 00:00:00 2001 From: Kota Tsuyuzaki Date: Mon, 9 Jan 2017 23:00:54 -0800 Subject: [PATCH] Clarify the variable name and add docs This is a follow-up for https://review.openstack.org/#/c/414723 Trivial-fix Change-Id: I647528d7c341181e74b814de81fccbed8bad5888 --- tests/unit/swift_middleware/handlers/test_base.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/unit/swift_middleware/handlers/test_base.py b/tests/unit/swift_middleware/handlers/test_base.py index 85b92971..6e471117 100644 --- a/tests/unit/swift_middleware/handlers/test_base.py +++ b/tests/unit/swift_middleware/handlers/test_base.py @@ -175,7 +175,11 @@ class TestStorletBaseHandler(unittest.TestCase): assert_not_implemented(method, path, headers) def test_parameters_from_headers(self): - def dummy_rip(): + def mock_request_property(): + """ + This is for skipping extract_vaco which causes NotImplementedError + if initialize StorletBaseHandler directly. + """ def getter(self): return self._request @@ -191,7 +195,7 @@ class TestStorletBaseHandler(unittest.TestCase): headers=headers) with mock.patch('storlets.swift_middleware.handlers.base.' - 'StorletBaseHandler.request', dummy_rip): + 'StorletBaseHandler.request', mock_request_property): handler = StorletBaseHandler( req, mock.MagicMock(), mock.MagicMock(), mock.MagicMock(), mock.MagicMock())