openstack/sunbeam-charms
Code Issues Proposed changes

Only emit process_op event when there's a request

Browse Source 
On relation creation / change, there's a timeframe where the request is
empty. In this case, the previous code returned an empty dict, that
could not be decoded by the json library.

Change-Id: I0a02be6d0d9382bacbd53aaa18a2f6d4a6d126c0
This commit is contained in:
Guillaume Boutry 2023-10-13 10:33:26 +02:00
parent 2719e015b8
commit 422e9448ff
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
charms/keystone-k8s/lib/charms/keystone_k8s/v0/identity_resource.py
View File

@ -117,7 +117,7 @@ LIBAPI = 0
# Increment this PATCH version before using `charmcraft publish-lib` or reset
# to 0 if you are raising the major API version
LIBPATCH = 3
LIBPATCH = 4
REQUEST_NOT_SENT = 1
@ -367,10 +367,11 @@ class IdentityResourceProvides(Object):
self, event: RelationChangedEvent
):
"""Handle IdentityResource changed."""
request = event.relation.data[event.relation.app].get("request", {})
self.on.process_op.emit(
event.relation.id, event.relation.name, request
)
request = event.relation.data[event.relation.app].get("request")
if request is not None:
self.on.process_op.emit(
event.relation.id, event.relation.name, request
)
def set_ops_response(
self, relation_id: str, relation_name: str, ops_response: dict