openstack/sunbeam-charms
Code Issues Proposed changes

Handle _private_key being None

Browse Source 
Recent change Ieffac3732c95846d0e3ec2408a9be4d96e477603 broke the
neutron-k8s py3 tests due to self.private_key being
accessed (_request_certificates method, `if self.private_key`)
before it had been properly set causing an attempt to decode None

Change-Id: I33bbf65e1d170cbc80161c573a381db43468b413
This commit is contained in:
Liam Young 2023-10-31 15:21:52 +00:00
parent 72ee41376c
commit cc5fe344b0
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ops-sunbeam/ops_sunbeam/relation_handlers.py
View File

@ -927,7 +927,11 @@ class TlsCertificatesHandler(RelationHandler):
def private_key(self):
"""Private key for certificates."""
logger.debug("Returning private key: {}".format(self._private_key))
return self._private_key.decode()
if self._private_key:
return self._private_key.decode()
else:
# Private key has not been set yet
return None
def update_relation_data(self):
"""Request certificates outside of relation context."""