Fix to handle correct path for BiosRegistry

The handler for Bios/BiosRegistry doesn't match the path in
bios_attribute_registry_file.json - it shouldn't have the
identity. This is also now consistent with the actual response
returned by vendors.

Change-Id: I719f99ae400134074ca47ccb8bed7df74ccb9b45

releasenotes/notes/fix-bios-registry-handler-63528fb2e114a04c.yaml

@@ -0,0 +1,7 @@
+---
+fixes:
+  - |
+    Fixes a bug in the handler for Bios/BiosRegistry - it should not include
+    identity in order to match the url returned from
+    bios_attribute_registry_file.json and be consistent with actual vendor
+    responses.

sushy_tools/emulator/main.py

@@ -827,12 +827,12 @@ def message_registry_file():
         'message_registry_file.json')
 
 
-@app.route('/redfish/v1/Systems/<identity>/Bios/BiosRegistry')
+@app.route('/redfish/v1/Systems/Bios/BiosRegistry')
 @returns_json
-def bios_registry(identity):
+def bios_registry():
     app.logger.debug('Serving BIOS registry')
 
-    return flask.render_template('bios_registry.json', identity=identity)
+    return flask.render_template('bios_registry.json')
 
 
 @app.route('/redfish/v1/Registries/Messages/Registry')

sushy_tools/emulator/templates/bios_registry.json

@@ -1,6 +1,6 @@
 {
   "@odata.context": "/redfish/v1/$metadata#AttributeRegistry.AttributeRegistry",
-  "@odata.id": {{ "/redfish/v1/Systems/%s/Bios/BiosRegistry"|format(identity)|tojson }},
+  "@odata.id": "/redfish/v1/Systems/Bios/BiosRegistry",
   "@odata.type": "#AttributeRegistry.v1_1_1.AttributeRegistry",
   "Description": "This registry defines a representation of BIOS Attribute instances",
   "Id": "BiosAttributeRegistryP89.v1_0_0",

sushy_tools/tests/unit/emulator/test_main.py

@@ -810,10 +810,9 @@ class RegistryTestCase(EmulatorTestCase):
 
     def test_bios_registry(self):
         response = self.app.get(
-            '/redfish/v1/Systems/%s/Bios/BiosRegistry' % self.uuid)
+            '/redfish/v1/Systems/Bios/BiosRegistry')
         self.assertEqual(200, response.status_code)
-        self.assertEqual('/redfish/v1/Systems/%s/Bios/BiosRegistry'
-                         % self.uuid,
+        self.assertEqual('/redfish/v1/Systems/Bios/BiosRegistry',
                          response.json['@odata.id'])
         self.assertEqual('BIOS Attribute Registry',
                          response.json['Name'])